Adapt Torbutton to the Australis UI

Assuming Australis hits stable when we are dealing with a TorBrowser based on Fx 31 we should streamline the Torbutton appearance in the toolbar. There are some rough edges due to the new UI paradigm.

added MikePerry201409R TorBrowserTeam201409 component::applications/tor browser ff31-esr owner::tbb-team priority::medium resolution::fixed status::closed tbb-torbutton tbb-usability type::enhancement labels

Trac:
Cc: N/A to intrigeri

This is also an opportunity to review the Torbutton UI and think about how to streamline it and make it better. Related bugs: #10632 (moved), #11175 (moved), #12514 (moved) (and others, I am sure)

Trac:
Cc: intrigeri to intrigeri, brade, mcs

Trac:
Keywords: N/A deleted, tbb-torbutton added
Component: TorBrowserButton to Tor Browser
Owner: mikeperry to tbb-team

Trac:
Cc: intrigeri, brade, mcs to intrigeri, brade, mcs, arthuredelstein@gmail.com

I have a branch at https://github.com/arthuredelstein/torbutton/commits/12620 that contains fixes for making Torbutton compatible with the esr31-port-untested build at https://github.com/arthuredelstein/tor-browser/commits/esr31-port-untested. (See also #12620 (moved))

Ideally, if these are all the changes we need for FF31esr, this new Torbutton would still work on FF24esr, so we don't have to make a separate branch for the 31esr series.

Is it possible to wrap that HUDService import in a try/catch or version check (as is done in torbutton_init())?

Yes, I think we can do this.

I've updated the branch to handle both ESR24 and ESR31 cases. I'm still working on it, in part because there's a weird bug with the popup menu where it only pops up on the second run of TBB.

In the medium term, it might be nice to fully adapt to the Australis style of popup panel. That probably means breaking backward compatibility, so perhaps that should wait until the ESR24 version is retired.

OK, I think it's fixed now. The popup menu now works on first run.

Replying to mikeperry:

Ideally, if these are all the changes we need for FF31esr, this new Torbutton would still work on FF24esr, so we don't have to make a separate branch for the 31esr series.

#10716 (moved) makes the ESR 31 Torbutton incompatible with the ESR 24 one unless we do some version detection within Torbutton and or just ship both the old and the new logic (as the current patch does), a thing I'd like to avoid.

Replying to gk:

Replying to mikeperry:

Ideally, if these are all the changes we need for FF31esr, this new Torbutton would still work on FF24esr, so we don't have to make a separate branch for the 31esr series.

#10716 (moved) makes the ESR 31 Torbutton incompatible with the ESR 24 one unless we do some version detection within Torbutton and or just ship both the old and the new logic (as the current patch does), a thing I'd like to avoid.

I can see good arguments both for and against using version detection. We could use version detection during the transition period bewteen ESRs and then delete code for ESR 24 after it's retired. What do you think? I'll post patches here for review once we've decided which way to go.

As this is affects only a short transition period and no huge changes seem to be involved I think having just one branch + version detection might be less overhead, yes.

Trac:
0001-Bug-10751.1-Load-HUDService-only-if-it-s-not-already.patch

Trac:
0002-Bug-10751.2-Adapt-Torbutton-to-Australis-UI.patch

Here's the patches for review. I've tested them in the latest version of TBB and the ESR31 branch at #12620 (moved).

Trac:
Status: new to needs_review

Trac:
Keywords: tbb-usability deleted, TorBrowserTeam201408, MikePerry201408Rtbb-usability added

Trac:
Keywords: MikePerry201408Rtbb-usability deleted, tbb-usability, MikePerry201408R added

Trac:
Keywords: TorBrowserTeam201408, MikePerry201408R deleted, MikePerry201409R, TorBrowserTeam201409 added

The patches look good to me.

Yep. Merged to origin/master.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #18980 (moved)

moved to tpo/applications/tor-browser#10751 (closed)

mentioned in issue tpo/applications/tor-browser#18980 (closed)