Ship Thai Tor Browser in alpha series

After the localization lab sprint, the Tor Browser locale files have been translated to Thai. please add them for testing to alpha!

Trac:
Parent Ticket: #29935 (moved)

added TorBrowserTeam201911R actualpoints::0.25 component::applications/tor browser owner::gk parent::29935 points::0.25 priority::medium resolution::fixed severity::normal status::closed type::enhancement labels

Moving tickets to June

Trac:
Keywords: TorBrowserTeam201905 deleted, TorBrowserTeam201906 added

Moving tickets to July

Trac:
Keywords: TorBrowserTeam201906 deleted, TorBrowserTeam201907 added

Moving more tickets to August

Trac:
Keywords: TorBrowserTeam201907 deleted, TorBrowserTeam201908 added

Moving tickets to September

Trac:
Keywords: TorBrowserTeam201908 deleted, TorBrowserTeam201909 added

Trac:
Points: N/A to 0.25

Trac:
Keywords: N/A deleted, TorBrowserTeam201910 added

Trac:
Keywords: TorBrowserTeam201909 deleted, N/A added

ey there!

the translators translated TBB in June, it can be a little demotivating to wait so long to see their results, is there a way to speed the addition of this translation, at least in alpha?

Replying to emmapeel:

ey there!

the translators translated TBB in June, it can be a little demotivating to wait so long to see their results, is there a way to speed the addition of this translation, at least in alpha?

Yes, there is. It would greatly speed up the process if you or someone else provided a patch for review, ideally with bundles built for all supported platforms.

We plan to do exactly that once the 9.5 alpha cycle starts and the 9.0 dust has settled. If you get to it earlier, please do.

Moving tickets to November 2019

Trac:
Keywords: TorBrowserTeam201910 deleted, TorBrowserTeam201911 added

assigning tickets to gk

Trac:
Status: new to assigned
Owner: tbb-team to gk

Trac:
Cc: gk, pili to gk, pili, tbb-team

I am seeing comment:1:ticket:30087 with the th bundle I have but that should not be a blocker. However, I fear th might suffer from #29257 (moved), too, which would be a blocker. So far the patches I have work on Android, Linux, and Windows 7.

I've uploaded a bundle for someone to test on Windows 10:

https://people.torproject.org/~gk/testbuilds/torbrowser-install-win64-tbb-nightly.2019.11.21_th.exe https://people.torproject.org/~gk/testbuilds/torbrowser-install-win64-tbb-nightly.2019.11.21_th.exe.asc

The branches for review: tor-browser-build: bug_30786_v2 (https://gitweb.torproject.org/user/gk/tor-browser-build.git/commit/?h=bug_30786_v2&id=715939330d3c62b8e075af620a41e0fd48cb54b5) tor-launcher: bug_30786 (https://gitweb.torproject.org/user/gk/tor-launcher.git/commit/?h=bug_30786&id=2a4089478815e6ff2f74b90aaf5723920d85542f) torbutton: bug_30786 (https://gitweb.torproject.org/user/gk/torbutton.git/log/?h=bug_30786 (last two commits))

Trac:
Status: assigned to needs_review
Keywords: TorBrowserTeam201911 deleted, TorBrowserTeam201911R added
Actualpoints: N/A to 0.25

Replying to gk:

[snip]

torbutton: bug_30786 (https://gitweb.torproject.org/user/gk/torbutton.git/log/?h=bug_30786 (last two commits))

There is actually no good reason to not squash those two commits. I moved forward with that idea in bug_30786_v2 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_30786_v2&id=3f32e7dd512f579e98a998b514e8d153e8c417a9).

Replying to gk:

Replying to emmapeel:

ey there!

the translators translated TBB in June, it can be a little demotivating to wait so long to see their results, is there a way to speed the addition of this translation, at least in alpha?

Yes, there is. It would greatly speed up the process if you or someone else provided a patch for review, ideally with bundles built for all supported platforms.

Sorry I didn't saw this before. @gk when you see this maybe you can point me to some documentation on how to do such a thing, if not this time, for next?

Patches seem good, thanks.

Picked as: torbutton: 5c87af5b0cee66f919e233d30a8dfec89c712222 tor-launcher: 39e7de2065d9fb6be0ed859844e97ead758fd7aa tor-browser-build: 73c2848ca10144988aff74a2a233171cb8624a23

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

changed time estimate to 2h

added 2h of time spent

mentioned in issue #29935 (moved)

moved to tpo/applications/tor-browser#30786 (closed)