Remove inline <script> in aboutTor.xhtml

We should move the inline script in aboutTor.xhtml to some .js file so that we can remove the 'unsafe-inline' from about:tor CSP. See #31322 (moved).

added 9.5a5 BugSmashFund TorBrowserTeam202001R actualpoints::0.25 component::applications/tor browser ff68-esr owner::tbb-team points::0.25 priority::medium resolution::fixed reviewer::brade reviewer::mcs severity::normal status::closed type::defect labels

Trac:
Keywords: N/A deleted, ff68-esr added

Tagging with Sponsor 44

Trac:
Sponsor: N/A to Sponsor44-can

Trac:
Points: N/A to 0.25

Trac:
Keywords: N/A deleted, TorBrowserTeam201909 added

Trac:
Keywords: N/A deleted, TorBrowserTeam201910 added

Trac:
Keywords: TorBrowserTeam201909 deleted, N/A added

Moving tickets to November 2019

Trac:
Keywords: TorBrowserTeam201910 deleted, TorBrowserTeam201911 added

Moving tickets to December

Trac:
Keywords: TorBrowserTeam201911 deleted, TorBrowserTeam201912 added

BugSmashFund can be used for the ESR work done so far

Trac:
Keywords: N/A deleted, BugSmashFund added

Sponsor 44 only covered PM and Team Lead work

Trac:
Sponsor: Sponsor44-can to N/A

Trac:
Keywords: TorBrowserTeam201912 deleted, TorBrowserTeam202001 added

Patch for review in https://github.com/acatarineu/torbutton/commit/31395.

Trac:
Actualpoints: N/A to 0.25
Keywords: TorBrowserTeam202001 deleted, TorBrowserTeam202001R added
Status: new to needs_review

Trac:
Reviewer: N/A to brade, mcs

Replying to acat:

Patch for review in https://github.com/acatarineu/torbutton/commit/31395.

Overall, the patch looks good. Kathy and I have one question/concern: are we OK with making all of the torbutton code accessible to content via contentaccessible=yes? If not, you could place the new aboutTor.js file in a subdirectory and only apply contentaccessible=yes to that subdirectory.

Thanks for the review, I revised the patch with your suggestion: https://github.com/acatarineu/torbutton/commit/31395+1.

Thanks! My only request is adding a license header in chrome/content/aboutTor/resources/aboutTor.js.

Trac:
Status: needs_review to needs_revision

Done in https://github.com/acatarineu/torbutton/commit/31395+2.

Trac:
Status: needs_revision to needs_review

Thanks! Let's see how this looks. Merged as f87cd0af7462faab1d349e28e7b17c76274624b0 on master.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed
Keywords: N/A deleted, 9.5a5 added

closed

changed time estimate to 2h

added 2h of time spent

moved to tpo/applications/tor-browser#31395 (closed)