Update libevent to 2.1.11-stable

https://github.com/libevent/libevent/releases

Trac:
Parent Ticket: #28704 (moved)

added TorBrowserTeam202004R component::applications/tor browser owner::sisbell parent::28704 points::1 priority::medium resolution::fixed reviewer::boklm reviewer::gk severity::normal status::closed tbb-rbm type::defect labels

Trac:
Keywords: N/A deleted, tbb-rbm added

With version 2.1.11 we don't need the osx patch anymore. The patch is included in the updated libevent version. The project builds across platforms

• windows x86_64 and i686
• osx,
• linux x86_64 and i686.

https://github.com/sisbell/tor-browser-build/commits/bug-31499a

Trac:
Status: new to needs_review
Cc: N/A to sysrqb, boklm, cypherpunks

Trac:
Cc: sysrqb, boklm, cypherpunks to sysrqb, boklm, cypherpunks, sisbell

Trac:
Status: needs_review to assigned
Cc: sysrqb, boklm, cypherpunks, sisbell to sysrqb, boklm, tbb-team
Owner: tbb-team to sisbell

The patch looks good to me, but I'd like a second review.

Trac:
Status: assigned to needs_review
Reviewer: N/A to boklm, gk

(specifically, commit c2fdb4de8a0468a29c18579a8b13042537f9f6c9).

I tried building tor for linux-x86_64 with this patch, but it failed with:

cp: cannot stat `/var/tmp/dist/libevent/lib/libevent-2.1.so.6': No such file or directory

Trac:
Status: needs_review to needs_revision
Keywords: N/A deleted, TorBrowserTeam202004 added

ugh. I almost asked about that. I noticed the last time we bumped the version we did:

diff --git a/projects/tor/build b/projects/tor/build
index bf7db832..c6d9895d 100644
--- a/projects/tor/build
+++ b/projects/tor/build
@@ -39,7 +39,7 @@ openssldir=/var/tmp/dist/openssl
   mkdir -p "$distdir/Debug/Tor"
   cp $openssldir/lib/libssl.so.1.0.0 "$distdir/Tor/"
   cp $openssldir/lib/libcrypto.so.1.0.0 "$distdir/Tor/"
-  cp $libeventdir/lib/libevent-2.0.so.5 "$distdir/Tor/"
+  cp $libeventdir/lib/libevent-2.1.so.6 "$distdir/Tor/"
   # We need to copy the libstdc++.so.6 for Tor Browser on older Linux distros.
   # Copying it into /Browser, which feels more natural, and amending
   # LD_LIBRARY_PATH breaks updates from a Tor Browser with the old

sisbell, all of your testbuilds were successful?

Replying to sysrqb:

ugh. I almost asked about that. I noticed the last time we bumped the version we did:

{{{ diff --git a/projects/tor/build b/projects/tor/build index bf7db832..c6d9895d 100644 --- a/projects/tor/build +++ b/projects/tor/build @@ -39,7 +39,7 @@ openssldir=/var/tmp/dist/openssl mkdir -p "$distdir/Debug/Tor" cp

$openssldir/lib/libssl.so.1.0.0 "$

distdir/Tor/" cp

$openssldir/lib/libcrypto.so.1.0.0 "$

distdir/Tor/"

• cp
  $libeventdir/lib/libevent-2.0.so.5 "$
  distdir/Tor/"

• cp
  $libeventdir/lib/libevent-2.1.so.6 "$
  distdir/Tor/"

We need to copy the libstdc++.so.6 for Tor Browser on older Linux distros.

Copying it into /Browser, which feels more natural, and amending

LD_LIBRARY_PATH breaks updates from a Tor Browser with the old

}}}

sisbell, all of your testbuilds were successful? I did go through each build including linux-x86_64, but I try again and see if I can reproduce this issue

With the update libevent-2.1.so.6 is now libevent-2.1.so.7:

lrwxrwxrwx root/root         0 2019-08-01 23:37 libevent/lib/libevent-2.1.so.7 -> libevent-2.1.so.7.0.0
-rwx------ root/root   1639593 2019-08-01 23:37 libevent/lib/libevent-2.1.so.7.0.0

Trac:
Points: N/A to 1

Trac:
Parent: N/A to #28765 (moved)

Changing parent ticket since it says max parent child depth too deep (over 5) whenever I try to comment

Trac:
Parent: #28765 (moved) to #28704 (moved)

I added the tor project change regarding libevent-2.1.so.7 to this ticket

https://github.com/sisbell/tor-browser-build/commits/bug-31499d

Trac:
Keywords: TorBrowserTeam202004 deleted, TorBrowserTeam202004R added
Status: needs_revision to needs_review

Replying to sisbell:

I added the tor project change regarding libevent-2.1.so.7 to this ticket

https://github.com/sisbell/tor-browser-build/commits/bug-31499d

Thanks, this looks good to me. I merged the commit to master with commit a017df805383561dde058f566255d709bc347834.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

changed time estimate to 8h

moved to tpo/applications/tor-browser#31499 (closed)