Backport fix for bug 1590538

Mozilla landed a fix for our #31764 (moved). We should backport their fix and remove our workaround

added GeorgKoppen202001 TorBrowserTeam202001R actualpoints::0.1 component::applications/tor browser owner::tbb-team points::0.1 priority::medium resolution::fixed reviewer::mcs severity::normal status::closed type::defect labels

Moving tickets to December

Trac:
Keywords: TorBrowserTeam201911 deleted, TorBrowserTeam201912 added

Moving my tickets to December.

Trac:
Keywords: GeorgKoppen201911 deleted, GeorgKoppen201912 added

Trac:
Keywords: TorBrowserTeam201912 deleted, TorBrowserTeam202001 added

No December anymore.

Trac:
Keywords: GeorgKoppen201912 deleted, GeorgKoppen202001 added

bug_32470 (https://gitweb.torproject.org/user/gk/tor-browser.git/commit/?h=bug_32470&id=b2f474aa84ee6768f02b9b1fe8b454119383db51) has a cleanly applying backport. I could not test the resulting build yet, though.

Trac:
Keywords: TorBrowserTeam202001 deleted, TorBrowserTeam202001R added
Status: new to needs_review
Actualpoints: N/A to 0.1

Trac:
Reviewer: N/A to mcs

r=brade, r=mcs

We tested by:

1. Backing out Richard's original patch for #31764 (moved) (commit 59d89229b68f8fbaa46e910a9bd03a6b26e8403e on tor-browser-68.4.1esr-9.5-1).
2. Building on Linux and then confirming that the original bug did occur.
3. Applying the patch from comment:5 (backport of Mozilla's fix).
4. Rebuilding and verifying that the original problem has disappeared again.

We also need to remember to drop Richard's original patch when we merge this one.

Thanks. I cherry-picked the patch to tor-browser-68.4.1esr-9.5-1 as commit d361b0b2c8e51cec5088233006be152c340b6553, and reverted the previous fix with commit 45677fd3bc4fd9b69216bb25efadcbac3026672f.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

changed time estimate to 48m

added 48m of time spent

moved to tpo/applications/tor-browser#32470 (closed)