I combined the configure_opt_project into this commit since it is needed as part of the configuration. I removed the android part which will be in #28765 (moved)
--disable-libevent-regress --disable-samples are for all projects now, so I just put them in the build file, as they don't need to be configurable per platform variant.
linux-x86_64: 1 osname: linux-x86_64+ configure_opt: '[% c("var/configure_opt_project") %]' # We only support RLBox on the nightly channel and x86_64 for now rlbox: '[% c("var/nightly") %]'
from linux-x86_64, and declare configure_opt under linux such that it is inherited by linux-x86_64 and any new Linux arch we add?
I combined the configure_opt_project into this commit since it is needed as part of the configuration. I removed the android part which will be in #28765 (moved)
--disable-libevent-regress --disable-samples are for all projects now, so I just put them in the build file, as they don't need to be configurable per platform variant.
There is no need for configure_opt_project to add the --disable-libevent-regress --disable-samples flags to projects/libevent/build. So I think it does not make sense to combine the configure_opt_project changes with this commit. Instead it should be a separate commit, or combined with the patch for #28765 (moved) (where configure_opt_project is needed).
But in order to avoid another round of reviews, I moved the configure_opt_project changes myself from the #33877 (moved) patch to the #28765 (moved) patch. I also fixed a typo in the commit message for #28765 (moved) (removing the - after Bug). This is now commits f4792f507d57583fce4f52afcb927076762653a1 (#33877 (moved)) and 06bb0f2d4c91d7ac60ae180297d3c0707a004199 (#28765 (moved)) on master.
Trac: Status: needs_review to closed Resolution: N/Ato fixed