Update site info URL with the onion name

After discussing onion names with the Freedom of the Press UX folks, they suggested showing a more explicit relationship between the origin .onion address and HTTPSeverywhere alias in our user interface.

We agreed on this idea and we planned to:

• update the site info at the identity doorhanger by showing the onion name
• allow users to see [more info]

added TorBrowserTeam202005R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed reviewer::antonela reviewer::sysrqb severity::normal status::closed type::defect ux-team labels

Trac:

FPF's iteration 

Stable


Trac:

TB9.5 stable - onion names

Patch for review in https://github.com/acatarineu/tor-browser/commit/34196.

I did not change the default styling, just replaced the site info URL. Not sure if the task also required to make "Site information for" nonbold.

Besides:

link users to a more info section in support.torproject.org/onionservices/onionnames Does this require a change from my side? I don't see where this link could go in the images you attached.

Trac:

Screenshot in https://trac.torproject.org/projects/tor/attachment/ticket/34196/34196.png.

Trac:
Status: new to needs_review
Keywords: ux-team deleted, ux-team TorBrowser202005R added

Trac:

Trac:

Actually, after taking a deeper look I revised the patch for a better approach I think: https://github.com/acatarineu/tor-browser/commit/34196+1 (00f5a4c995a911423e10af5a2bbeceef1ae76be6).

Also see the side panel https://trac.torproject.org/projects/tor/attachment/ticket/34196/34196_side.png and the more info window https://trac.torproject.org/projects/tor/attachment/ticket/34196/34196_moreinfo.png. The side panel still displays the friendly host, but more info window displays the actual, long .onion. I think this fine, but please review :)

This is great. Also the [more info] link is the right place to show the origin onion as well.

I updated the ticket and after the code review, we can close it.

Thanks acat!

Trac:
Description: After discussing onion names with the Freedom of the Press UX folks, they suggested showing a more explicit relationship between the origin .onion address and HTTPSeverywhere alias in our user interface.

We agreed on this idea and we planned to:

• update the site info at the identity doorhanger by showing the onion name
• link users to a more info section in support.torproject.org/onionservices/onionnames

to

After discussing onion names with the Freedom of the Press UX folks, they suggested showing a more explicit relationship between the origin .onion address and HTTPSeverywhere alias in our user interface.

We agreed on this idea and we planned to:

• update the site info at the identity doorhanger by showing the onion name
• allow users to see [more info]

This looks great, thanks very much for the super quick iteration. On the SecureDrop team we're very excited about this functionality, as you can imagine. :-)

Is it feasible to add any additional data to the "More information" panel, e.g., to clarify the relationship between alias and .onion address?

Something like:

HTTPSEverywhere Alias: lucyparsonslabs.securedrop.tor.onion

(Or better terminology that's consistent with your goals for the project.)

Trac:
Username: eloquence

Replying to acat:

I did not change the default styling, just replaced the site info URL. Not sure if the task also required to make "Site information for" nonbold.

I agree, we should continue using Firefox's styling.

Replying to eloquence:

Is it feasible to add any additional data to the "More information" panel, e.g., to clarify the relationship between alias and .onion address?

Something like:

HTTPSEverywhere Alias: lucyparsonslabs.securedrop.tor.onion

(Or better terminology that's consistent with your goals for the project.)

Are you imagining adding another line below "Website:" or "Verified by:"? I suggest we use a more generic term, like "Onion Alias" or "Onion Name".

Replying to sysrqb:

more generic term, like "Onion Alias" or "Onion Name".

Both, Onion Alias or Onion Name works for me.

After this, we can stick to the picked version for our communication.

I like all of them. That said, I think "Alias" is a weird computer term. "Name" is a very simple term that everyone understands but perhaps might be confusing to people because then what's the onion address? But it also fits into the narrative of onion address is the IP address, and short-hand names are the DNS names. Another alternative would be "Onion Nickname".

All in all, I would go with anything here, with a small preference to "Name".

Replying to acat:

Actually, after taking a deeper look I revised the patch for a better approach I think: https://github.com/acatarineu/tor-browser/commit/34196+1 (00f5a4c995a911423e10af5a2bbeceef1ae76be6).

The patch looks good, thanks! I merged it with commit 2e16915ff1a6933090dfb47e6fc876ea056cf07c.

I also opened #34225 (moved), for a later time.

I'll take the More Info panel patch as a fixup commit (but I wanted to land the above patch). We can get it into the alpha if it's ready by tomorrow night.

Trac:
Status: needs_review to needs_revision
Keywords: ux-team TorBrowser202005R deleted, ux-team TorBrowser202005 added

Trac:

Here are patches for review: https://github.com/acatarineu/tor-browser/commit/34196+2 and https://github.com/acatarineu/torbutton/commit/34196.

I added the "Onion Name" entry in the page info, below Website: (https://trac.torproject.org/projects/tor/attachment/ticket/34196/pageinfo_onionname.png).

Trac:
Keywords: ux-team TorBrowser202005 deleted, ux-team TorBrowser202005R added
Status: needs_revision to needs_review

Thanks acat!

I merged the torbrowser fixup with commit a87a532c070322f8ba252da6a577c872d07d53b3, and the torbutton patch with 96321fdd1715f52cab00f6654ebc8fb420a5489d.

Trac:
Keywords: ux-team TorBrowser202005R deleted, ux-team TorBrowserTeam202005R added
Status: needs_review to closed
Resolution: N/A to fixed

\o/

closed

moved to tpo/applications/tor-browser#34196 (closed)