Add What's New Onboarding Item

https://trac.torproject.org/projects/tor/ticket/31660#comment:20

""" We should have something included in the 9.5 release onboarding for the new features. Antonela and I decided we can have one new entry named "What's New" (following Mozilla's new onboarding experience). This entry simply has a link to a webpage where new features are described.

The webpage is currently being developed at ​https://www.torproject.org/releases/tor-browser-95/ """

Trac:
Parent Ticket: #31660 (moved)

added TorBrowserTeam202005R component::applications/tor browser owner::tbb-team parent::31660 priority::medium resolution::fixed severity::normal status::closed tbb-9.5 type::defect ux-team labels

I have a branch for review at:

https://gitweb.torproject.org/user/sysrqb/tor-browser.git/commit/?h=bug34321_00&id=dec624caf1ff737e5f0ccee81849707895bd9d8a

testbuilds: https://people.torproject.org/~sysrqb/bug34321/tor-browser-linux64-testbuild_en-US_01.tar.xz https://people.torproject.org/~sysrqb/bug34321/TorBrowser-testbuild-osx64_en-US_01.dmg

I'm not very happy about my choice of strings.

Based on brade and mcs' suggestions in comments [ticket:31660#comment:24 24], [ticket:31660#comment:25 25], and [ticket:31660#comment:26 26], the Onboarding experience behavior is now different between new installations and upgrades. After upgrading, a user should see the Onboarding bubble ("See what's new in Tor Browser") and when that is clicked the "Release Notes" webpage should open in a separate tab. At the same time, the Onboarding tour is marked as completed and the bubble is hidden on about:tor. The onboarding overlay is never shown to the user.

With a new installation, the user sees the current onboarding overlay with the addition of a "Learn More" tab. The major changes in this situation are when the user clicks the "Done" button on the Onion Services tour and when the user directly clicks on the "Learn More" tab. In both of these cases the "Release Notes" page is opened in a separate tab, the "Learn More" item is marked as completed, and the overlay is hidden.

Continuing to use "Done" as the string on Onion Services button is possibly confusing, but the behavior is nearly the same as before.

Trac:
Cc: antonela, acat to antonela, acat, gk, mcs, brade
Status: new to needs_review

For testing the update scenario:

1. Open about:config
2. Change browser.onboarding.state to default (if not currently)
3. Change browser.onboarding.tour-type to update (it should be new)

about:tor should automatically notice these changes and provide the new behavior.

Works for me.

After discussing this on #tor-dev, gk and mcs reviewed the patch.

I rebased the patch onto tor-browser-68.9.0esr and merged it as commit db3ccb2a11256421f5d8db7caad10a5a2c98def5 on tor-browser-68.9.0esr-9.5-1. I cherry-picked it as commit d9016507dc5dd4910023b29df339aff63fd5d9a1 onto tor-browser-68.9.0esr-10.0-1.

Thanks everyone!

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #31660 (moved)

moved to tpo/applications/tor-browser#34321 (closed)