Avoid static /tmp usage

Stem's tests have at least a couple places where it uses a static /tmp location...

• The RUN_SOCKET target uses '/tmp/stem_integ/socket' as the control socket.
• The process integ tests use '/tmp/stem_integ' as tor's data directory.

We should use the tempfile module to a pick dynamic testing location instead. Issue reported by Dererk.

added component::archived/stem easy owner::atagar priority::low resolution::fixed status::closed testing type::defect labels

Trac:
Keywords: testing deleted, testing easy added

Trac:
Username: Abhishek Kumar Singh

patch

Trac:
Username: Abhishek Kumar Singh

From http://docs.python.org/2/library/tempfile.html tempfile.mkdtemp() - "Creates a temporary directory in the most secure manner possible. There are no race conditions in the directory’s creation. The directory is readable, writable, and searchable only by the creating user ID."

Trac:
Username: Abhishek Kumar Singh
Status: new to needs_review

Hi Abhishek. mkdtemp() is to make a temporary directory so the usage in test/integ/process.py is correct, but CONTROL_SOCKET_PATH is a file so that'll cause problems. If you run "run_tests.py --integ --target RUN_SOCKET" then I suspect that you'll encounter an issue.

For test/integ/process.py it would also be nice if we cleaned up the temporary resource after those tests have completed, otherwise each test run will make a new temporary directory.

Trac:
Status: needs_review to needs_revision

Trac:
Username: Abhishek Kumar Singh

patch1

Trac:
Username: Abhishek Kumar Singh

Please review attachment patch1.

Trac:
Username: Abhishek Kumar Singh

Hi Abhishek. Python conventions say that global constants are in all capital letters (like DATA_DIRECTORY), and instance variables are lowercase. Please swap it over to self.data_directory.

Have you tested this with 'run_tests.py --integ --target RUN_SOCKET'?

Trac:
Username: Abhishek Kumar Singh

patch2

Trac:
Username: Abhishek Kumar Singh

Done.Please review patch2

Have you tested this with 'run_tests.py --integ --target RUN_SOCKET'? Yes I have, it passed well except for tests I reported yesterday in ticket https://trac.torproject.org/projects/tor/ticket/8157 but that's not related with it so the changes works fine.

Trac:
Username: Abhishek Kumar Singh

Patch pushed. Thanks!

https://gitweb.torproject.org/stem.git/commitdiff/3687dde657dc8df40ffecadd45c4035ee3d44110

Trac:
Status: needs_revision to closed
Resolution: N/A to fixed

closed