Missing 'GETINFO md/all'

Hi Nick. The control spec has GETINFO options to fetch a microdescriptor via its fingerprint or nickname ('md/id/' and 'md/name/') but no method for getting them all (like 'ns/all' or 'desc/all-recent').

Processing all descriptors is a pretty common need, hence the priority (feel free to lower it if appropriate). In the meantime I'll hack around this in stem by having controller read microdescriptors from the data directory.

changed milestone to %Tor: 0.3.5.x-final

added component::core tor/tor microdesc milestone::Tor: 0.3.5.x-final owner::rl1987 priority::high resolution::fixed reviewer::asn severity::normal status::closed tor-client tor-control type::enhancement labels

I'll leave this as major. Timing makes it 0.2.5.

I'm assuming it's not a problem for you that microdescriptors don't tell you which microdescriptor they are unless you compute their SHA256 themselves? That is, unless you know the corresponding entry from the consensus networkstatus, you won't know which microdesc is which node.

Trac:
Milestone: N/A to Tor: 0.2.5.x-final
Keywords: N/A deleted, tor-client added

I'm assuming it's not a problem for you that microdescriptors don't tell you which microdescriptor they are unless you compute their SHA256 themselves?

It's not ideal. I was a bit sad yesterday when I realized that they lack the fingerprint since it changes simple tasks like 'tell me all of the exits' from...

for desc in controller.get_microdescriptors():
  if desc.exit_policy.is_exiting_allowed():
    print "%s is an exit" % desc.fingerprint

... to...

exit_onion_keys = set()

for desc in controller.get_microdescriptors():
  if desc.exit_policy.is_exiting_allowed():
    exit_onion_keys.add(desc.onion_key)

for desc in controller.get_network_statuses():
  if desc.digest in exit_onion_keys:
    print "%s is an exit" % desc.fingerprint

But not the end of the world. :)

FWIW, that's almost right, but the thing that you have in the networkstatus is not a digest of the onion key, but rather a digest of the microdescriptor. So you have to do something like :

for desc in controller.get_microdescriptors():
  if desc.exit_policy.is_exiting_allowed():
    exit_digests.add(sha256(str(desc.text))) # or whatever this is called

for desc in controller.get_network_statuses():
  if desc.digest in exit_digests:
    print "%s is an exit" % desc.fingerprint

Trac:
Milestone: Tor: 0.2.5.x-final to Tor: 0.2.???

Milestone renamed

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.3.???

Finally admitting that 0.3.??? was a euphemism for Tor: unspecified all along.

Trac:
Milestone: Tor: 0.3.??? to Tor: unspecified
Keywords: N/A deleted, tor-03-unspecified-201612 added

Remove an old triaging keyword.

Trac:
Keywords: tor-03-unspecified-201612 deleted, N/A added

Trac:
Keywords: tor-client deleted, tor-client tor-control microdesc added
Type: defect to enhancement
Reviewer: N/A to N/A
Sponsor: N/A to N/A
Severity: N/A to Normal

Trac:
Owner: N/A to rl1987
Status: new to accepted

https://github.com/torproject/tor/pull/122

I suppose integration test should be done in stem?

Trac:
Status: accepted to needs_review

Putting in 0.3.5 because 0.3.4 is closed to new features.

Do we have unit tests for control commands? If we do, then please add a unit test.

Yes, please add a stem integration test, maybe ask atagar how it's done.

And we'll also need a control spec patch.

Please open child tickets for stem and the control spec, so we can merge those patches separately if we need to.

Trac:
Milestone: Tor: unspecified to Tor: 0.3.5.x-final

Trac:
Reviewer: N/A to asn

Thanks for the code!

I did an initial review on your PR! Some small changes will be needed, but you are pretty much there.

Also, perhaps we should have some unittests for this new control command. SEe src/test/test_controller.c for some examples of other getinfo unittests.

Cheers!

Trac:
Status: needs_review to needs_revision

Fixed the code to use existing function and wrote unit tests.

Trac:
Status: needs_revision to needs_review

Squashed the branch again: https://github.com/torproject/tor/pull/137

LGTM!

Trac:
Status: needs_review to merge_ready

Merged!

Please close or un-parent the child tickets as appropriate, and then close this?

#26210 (closed) hasn't been implemented, so I un-parented it.

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

mentioned in issue #26210 (closed)

mentioned in issue #26211 (moved)

moved to tpo/core/tor#8323 (closed)