Test failing to clean up /tmp resources

After several test runs I noticed that we had accumulated quite a few temporary resources. This is from use of the tempfile module, at some point we're creating resources but failing to clean 'em up.

added component::archived/stem easy owner::atagar priority::very low resolution::fixed status::closed testing type::defect labels

Trac:
Username: ashishnitinpatil
Cc: N/A to cool_asis_is@yahoo.in

In stem/runner.py line 286 - self._test_dir = tempfile.mktemp("-stem-integ") Should it not be mkstemp rather than mktemp? Also, would running a os.rmdir(tempfile.gettempdir()) be sufficient after being done with the tests? Also, would not tempfile.TemporaryFile() (Deletes the temp files automatically) be a better thing to do rather than mkstemp? Or do we need the files later for some other tests?

Trac:
Username: ashishnitinpatil

In stem/runner.py line 286 - self._test_dir = tempfile.mktemp("-stem-integ")

Stem has a 'integ.test_directory' config option set by default so in practice no one ever hits this line (... maybe we should remove it). This is from when I first started writing stem's tests and thought that developers would always want a fresh data directory for tor. In practice it's simple enough to blow away './test/data'.

So long story short your princess is in another castle - this is not the line making the temporary resources. Have you tried running the integ tests to see what is being created in /tmp?

No, I have not run the tests (any of them) as yet. Still learning stuff. Will get better with time I hope. Thanks, I'll do that & then maybe get a better look at actually seeing the tests do their work rather skimming through the code.

Trac:
Username: ashishnitinpatil

Ok, so I wrote up a few python lines at the end of main() in run_tests.py to clear up whatever is there under CONFIG["integ.test_directory"]. But, for some reason, a .fuse_file is getting generated which refuses to be deleted & thus the directory can not be cleared. Any suggestions or insights?

Trac:
Username: ashishnitinpatil

https://pastee.org/cvnx

Trac:
Username: ashishnitinpatil

But, for some reason, a .fuse_file is getting generated which refuses to be deleted & thus the directory can not be cleared. Any suggestions or insights?

That isn't from stem, sounds like...

https://en.wikipedia.org/wiki/FUSE_%28filesystem%29

https://pastee.org/cvnx

Good try, but that isn't the goal of this ticket. The test_directory is where we place tor's data directory and we want to keep that so subsequent test runs are faster. This ticket is about stuff being left in /tmp.

Finally, got what was creating the temporary folder. Apparently, the files were automatically getting deleted but since we used mkdtemp() in runner.py (after import in run_tests.py) we have to manually delete the temp folder. The following does the work successfully (tested on Windows & Linux) - (I coded this into run_tests.py at about the end of main())

TEMP_DIR = os.path.dirname(test.runner.CONTROL_SOCKET_PATH)
try:
  os.rmdir(TEMP_DIR)
  println("SUCCESSFULLY CLEANED TEMP RESOURCE AT - %s"%TEMP_DIR)
except:
  println("FAILED TO CLEAN TEMP RESOURCE AT - %s"%TEMP_DIR)

Trac:
Username: ashishnitinpatil
Status: new to needs_review

Trac:
Username: ashishnitinpatil
Cc: cool_asis_is@yahoo.in to cool_asis_is@yahoo.in, ashishnitinpatil@gmail.com

Thanks, fix pushed...

https://gitweb.torproject.org/stem.git/commitdiff/13dc7861ae7bfa280fda8536ca39fcf6135d7b56

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed