Ticket #22501: 0001-Bug-22501-Requests-via-javascript-violate-FPI.patch

File 0001-Bug-22501-Requests-via-javascript-violate-FPI.patch, 3.3 KB (added by pospeselr, 18 months ago)

Properly formatted patch with a real commit message and everything

  • projects/tor-browser/Bundle-Data/linux/Data/Browser/profile.default/preferences/extension-overrides.js

    From a599ef17c20b69d09ed29d170ede2bf9b7b6a908 Mon Sep 17 00:00:00 2001
    From: Richard Pospesel <richard@torproject.org>
    Date: Thu, 28 Sep 2017 12:32:58 -0700
    Subject: [PATCH] Bug 22501: Requests via javascript: violate FPI
    
    By default NoScript attempts to find URLs in "javascript:.*" strings
    found in <a> element href atributes and in <option> element value
    attributes.  When such links (or options) are clicked/selected,
    NoScript attempts to navigate the page to said URL.  These navigations
    are treated as intternal requests, and get pacced onto the catch-all
    circuit.
    
    This behaviour can be turned off by disabling the 'noscript.fixLinks'
    flag, so we do so for each Tor Browser build target's
    extension-overrides.js.
    ---
     .../Data/Browser/profile.default/preferences/extension-overrides.js      | 1 +
     .../Data/Browser/profile.default/preferences/extension-overrides.js      | 1 +
     .../Data/Browser/profile.default/preferences/extension-overrides.js      | 1 +
     3 files changed, 3 insertions(+)
    
    diff --git a/projects/tor-browser/Bundle-Data/linux/Data/Browser/profile.default/preferences/extension-overrides.js b/projects/tor-browser/Bundle-Data/linux/Data/Browser/profile.default/preferences/extension-overrides.js
    index ded3d5b..c610aff 100644
    a b pref("noscript.temp", ""); 
    3838pref("noscript.untrusted", "");
    3939pref("noscript.forbidMedia", false);
    4040pref("noscript.allowWhitelistUpdates", false);
     41pref("noscript.fixLinks", false);
    4142// Now handled by plugins.click_to_play
    4243pref("noscript.forbidFlash", false);
    4344pref("noscript.forbidSilverlight", false);
  • projects/tor-browser/Bundle-Data/mac/TorBrowser/Data/Browser/profile.default/preferences/extension-overrides.js

    diff --git a/projects/tor-browser/Bundle-Data/mac/TorBrowser/Data/Browser/profile.default/preferences/extension-overrides.js b/projects/tor-browser/Bundle-Data/mac/TorBrowser/Data/Browser/profile.default/preferences/extension-overrides.js
    index ded3d5b..c610aff 100644
    a b pref("noscript.temp", ""); 
    3838pref("noscript.untrusted", "");
    3939pref("noscript.forbidMedia", false);
    4040pref("noscript.allowWhitelistUpdates", false);
     41pref("noscript.fixLinks", false);
    4142// Now handled by plugins.click_to_play
    4243pref("noscript.forbidFlash", false);
    4344pref("noscript.forbidSilverlight", false);
  • projects/tor-browser/Bundle-Data/windows/Data/Browser/profile.default/preferences/extension-overrides.js

    diff --git a/projects/tor-browser/Bundle-Data/windows/Data/Browser/profile.default/preferences/extension-overrides.js b/projects/tor-browser/Bundle-Data/windows/Data/Browser/profile.default/preferences/extension-overrides.js
    index ded3d5b..c610aff 100644
    a b pref("noscript.temp", ""); 
    3838pref("noscript.untrusted", "");
    3939pref("noscript.forbidMedia", false);
    4040pref("noscript.allowWhitelistUpdates", false);
     41pref("noscript.fixLinks", false);
    4142// Now handled by plugins.click_to_play
    4243pref("noscript.forbidFlash", false);
    4344pref("noscript.forbidSilverlight", false);