Custom Query (23021 matches)


Show under each result:

Results (43 - 45 of 23021)

Ticket Resolution Summary Owner Reporter
#30428 fixed sendme: Failure to validate authenticated SENDMEs client side dgoulet dgoulet

Turns out that we have two issues with sendme_is_valid() (new authenticated SENDMEs).

  1. We can not fallback onto version 0 if the version of the cell is unrecognized. Right now, if let say we have a minimum version (from consensus) of 1 and then we support version 3 but we get version 4, then ultimately we will end up in defaulting to version 0. Not good.

There needs to be a strong check on what we can minimally support (from consensus) and the upper bound of what we support. Anything outside of that range, the circuit has to be closed.

  1. This one is a bit more bad. Basically, sendme_process_circuit_level() needs to validate the SENDME for both client and service. SENDMEs authenticate both ways and thus can not only be on service side like it is right now.

In other words, we need to call sendme_is_valid() in both cases that is if we are origin circuit or not.

Now that we have the unit test predictable fast prng feature, we should really add a tests that makes sure this entire logic works by sending 100 cells and expecting a SENDME validation.

Thanks to armadev's review for spotting those big issues!

#30425 fixed Revert changes for #30388 as needed tbb-team gk

A better patch for #30388 landed on esr60 ( We should revert our patches where needed.

#30422 fixed test.integ.control.controller failing for tor 2.x atagar 0xrichard

Some tests are failing for tor 2.x

Is this something for me to look into?

ERROR: test_without_ephemeral_hidden_services
Traceback (most recent call last):
  File "/data/workspace/stem/test/", line 57, in wrapped
    return func(self, *args, **kwargs)
  File "/data/workspace/stem/test/", line 57, in wrapped
    return func(self, *args, **kwargs)
  File "/data/workspace/stem/test/integ/control/", line 620, in test_without_ephemeral_hidden_services
    self.assertEqual([], controller.list_ephemeral_hidden_services())
  File "/data/workspace/stem/stem/", line 498, in wrapped
    return func(self, *args, **kwargs)
  File "/data/workspace/stem/stem/", line 3100, in list_ephemeral_hidden_services
    result += self.get_info('onions/current').split('\n')
  File "/data/workspace/stem/stem/", line 498, in wrapped
    return func(self, *args, **kwargs)
  File "/data/workspace/stem/stem/", line 1243, in get_info
    stem.response.convert('GETINFO', response)
  File "/data/workspace/stem/stem/response/", line 124, in convert
  File "/data/workspace/stem/stem/response/", line 54, in _parse_message
    raise stem.OperationFailed(error_code, error_msg)
stem.OperationFailed: No onion services of the specified type.


TESTING FAILED (33 seconds)
  [RUN_OPEN] test_ephemeral_hidden_services_v2 (test.integ.control.controller.TestController) ... ERROR
  [RUN_OPEN] test_with_detached_ephemeral_hidden_services (test.integ.control.controller.TestController) ... ERROR
  [RUN_OPEN] test_with_ephemeral_hidden_services_basic_auth (test.integ.control.controller.TestController) ... ERROR
  [RUN_OPEN] test_without_ephemeral_hidden_services (test.integ.control.controller.TestController) ... ERROR
Note: See TracQuery for help on using queries.