Custom Query (24740 matches)

Last week I started working on #24028. But after making a few local commits I realized that there's one major issue that makes this task harder than it should be: external dependencies to metrics-lib's implementation classes.

Some background: The idea behind metrics-lib was to provide a library for parsing descriptors. It contains one package with interfaces and another package with implementations of those interfaces. External applications, including our own, shall only depend on the first package, so that we can make changes to the second package at any time.

After a while we started sharing code (not interfaces) from metrics-lib in other applications, including code to parse index.json files or code to sanitize web server logs. And even though sharing code is a good idea in many cases, it sometimes comes at the cost of creating unwanted dependencies. I'd rather want to turn metrics-lib into just the descriptor-parsing library as it was before and share more generic code between all code bases in another way than stuffing it into metrics-lib.

Here's my suggestion: We remove external dependencies to metrics-lib's impl, index, internal, and log packages, put out a set of releases, refactor those packages including renaming them as planned in #24028, and finally come up with a better plan for sharing code between modules.

I'm going to post two branches for review here in a minute.

we saw this weekend that the cache servers do not reboot properly. when they return, @/run/nginx@ doesn't exist which crashes the nginx startup. those directories would need to be created on boot and it's unclear to me why they aren't. maybe @/var/run/nginx@ does exist instead?

Someone reported having this error on the blog:

EFF (Full): A new ruleset bundle has been released, but it is older than the extension-bundled rulesets it replaces. Skipping. util.js:26:15

​https://blog.torproject.org/comment/285690#comment-285690