Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#10016 closed defect (fixed)

TypeError in pyptlib subproc on Windows

Reported by: dcf Owned by: asn
Priority: Medium Milestone:
Component: Circumvention/Pluggable transport Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: #10006 Points:
Reviewer: Sponsor:

Description

Running obfs-flash-client on Windows gives me this error:

Traceback (most recent call last):
  File "obfs-flash-client", line 11, in <module>
    from pyptlib.util.subproc import auto_killall, Popen
  File "pyptlib\util\subproc.py", line 31, in <module>
    _Popen_defaults['creationflags'] |= subprocess.CREATE_NEW_PROCESS_GROUP
TypeError: list indices must be integers, not str

Child Tickets

Attachments (1)

0001-Update-creationflags-in-list-value-of-_Popen_default.patch (1.5 KB) - added by dcf 7 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 7 years ago by dcf

Status: newneeds_review

I ran into this while working on the Windows code in #10006. Here's a patch to do what I think the code is intending to do.

comment:2 Changed 7 years ago by dcf

Parent ID: #10006

comment:3 Changed 7 years ago by infinity0

Owner: changed from infinity0 to asn
Status: needs_reviewassigned

comment:4 Changed 7 years ago by asn

Resolution: fixed
Status: assignedclosed

Merged. Thanks!

comment:5 Changed 7 years ago by dcf

Good catch with the del tmp.

Note: See TracTickets for help on using tickets.