Opened 6 years ago

Closed 12 months ago

#10053 closed defect (wontfix)

vidalia-0.2.20: 2 * bad if test ?

Reported by: dcb Owned by: chiiph
Priority: Medium Milestone:
Component: Archived/Vidalia Version:
Severity: Normal Keywords: archived-closed-2018-07-04
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I just compiled vidalia-0.2.20 with extra gcc compiler flag -Wlogical-op

It said

1.

vidalia-0.2.20/src/torcontrol/Circuit.cpp:82:17: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]

Source code is

if (c < '0' && c > '9' && c < 'A' && c > 'Z' && c < 'a' && c > 'z')

Suggest swap && for

2.

vidalia-0.2.20/src/torcontrol/Stream.cpp:92:17: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]

Duplicate.

Child Tickets

Change History (3)

comment:1 Changed 6 years ago by nickm

Component: - Select a componentVidalia
Owner: set to chiiph

comment:2 Changed 19 months ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

comment:3 Changed 12 months ago by teor

Keywords: archived-closed-2018-07-04 added
Resolution: wontfix
Status: newclosed

Close all tickets in archived components

Note: See TracTickets for help on using tickets.