Opened 6 years ago

Closed 5 years ago

#10077 closed enhancement (fixed)

Build mingw-w64 compiler for TBB bundles from source

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-3.0, gitian, tbb-gitian
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

With #9084 landed in TBB 3.0b1 we are already building mingw-w64 from source to ship our runtime libraries linked against msvcr100. We should build upon this work and use it for building the Windows TBBs, too.

Child Tickets

Change History (7)

comment:1 Changed 6 years ago by gk

Keywords: gitian added

comment:2 Changed 5 years ago by erinn

Component: Tor bundles/installationTor Browser
Keywords: tbb-gitian added
Owner: changed from erinn to tbb-team

comment:3 Changed 5 years ago by erinn

Status: newneeds_review

I believe this is fixed in my tbb-4.x-hardening branch.

comment:4 in reply to:  3 Changed 5 years ago by gk

Replying to erinn:

I believe this is fixed in my tbb-4.x-hardening branch.

Looks good. Could you take care of https://gitweb.torproject.org/builders/tor-browser-bundle.git/blob/8a552ff03c226c3d1f5fa3ae0b4950cc03c0f678:/gitian/descriptors/windows/gitian-utils.yml#l54 as well (+ the respective parts in mkbundle-windows.sh and the three comment lines in gitian-tor.yml right before exporting PATH)? We don't need that anymore if this bug is fixed.

comment:5 Changed 5 years ago by erinn

I fixed it and rebased the branch so it's included in the regular Windows hardening commit.

comment:6 Changed 5 years ago by gk

While we don't need a separate binutils anymore we might want to be able to upgrade it without upgrading mingw-w64. It seems we can't do that with the new current patch. Maybe we should go for the simplest thing like adding touch binutils-$BINUTILS_VER-win32-utils.zip near the end of the utils descriptor and just check for binutils' existence (without adding any links) in mkbundle-windows.sh?

Last edited 5 years ago by gk (previous) (diff)

comment:7 in reply to:  6 Changed 5 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to gk:

While we don't need a separate binutils anymore we might want to be able to upgrade it without upgrading mingw-w64. It seems we can't do that with the new current patch. Maybe we should go for the simplest thing like adding touch binutils-$BINUTILS_VER-win32-utils.zip near the end of the utils descriptor and just check for binutils' existence (without adding any links) in mkbundle-windows.sh?

Just did that myself in commit 5a3ca06d4d031019aadc0a50aa209a5ca86c2b3f.

Note: See TracTickets for help on using tickets.