Opened 7 years ago

Closed 7 years ago

#10085 closed defect (fixed)

New event codes missing from SETEVENTS section

Reported by: atagar Owned by:
Priority: Very Low Milestone:
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Hi, a recent spec change added several new event types (CONN_BW, CIRC_BW, etc) but didn't add them to the SETEVENTS listing (section 3.4):

https://gitweb.torproject.org/torspec.git/blob/HEAD:/control-spec.txt#l292

Very trivial mistake. That said, I wouldn't be surprised if it's missing other event types too (it's error prone to expect spec changers to update both this and section 4.x when adding events). Maybe we should simply drop this listing?

Child Tickets

Change History (2)

comment:1 Changed 7 years ago by atagar

Status: newneeds_review

Pushed the proposed change to the 10085 branch of my spec repo (change).

comment:2 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed

Merged; thanks!

Note: See TracTickets for help on using tickets.