Opened 5 years ago

Closed 5 years ago

#10106 closed enhancement (fixed)

Merge in jpds/master repo

Reported by: cypherpunks Owned by: pde
Priority: Medium Milestone:
Component: HTTPS Everywhere/EFF-HTTPS Everywhere Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:



Can someone please merge in my repo of https-everywhere into the mainline repo?

Nice tricks I've included are a 'precommit' hook:

And also a load of rulesets and changes to existing ones:

Child Tickets

Change History (4)

comment:1 Changed 5 years ago by pde

Status: newneeds_review

comment:2 Changed 5 years ago by schoen

I made some changes to trivial-validate to make this pre-commit hook better handle a few cases.

I think the pre-commit hook works great now, although it produces different output in the commit message editor if you git commit a modified file without first git adding it. (The process still works, and the output is arguably correct; you get told that there are changes [that you're committing!] that haven't been staged for commit. You wouldn't be told this without the pre-commit hook.)

We also have a commit hook written by Yan which I think is meant to run server-side. We could probably benefit from using both of them, and from adding even more tests to trivial-validate. :-)

I'll try to pull in jpds's hook and apply a couple of my changes to it.

comment:3 Changed 5 years ago by cypherpunks

Can you please merge in the rest of the repo? The precommit script wasn't the only thing I contributed - there's several new rulesets and fixes.

comment:4 Changed 5 years ago by schoen

Resolution: fixed
Status: needs_reviewclosed

Thanks, I merged the rest of it. There's a lot of useful stuff there.

I reverted two changes that moved dots outside of optional initial regular expressions, because with the dot mandatory without the rest, you could match things like

instead of only or

Note: See TracTickets for help on using tickets.