Opened 7 years ago

Closed 7 years ago

Last modified 3 years ago

#10126 closed defect (fixed)

TBB-3.0-beta-1 include a non-stripped firefox binary

Reported by: isis Owned by: mikeperry
Priority: Immediate Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Normal Keywords: tbb-3.0-stable-blocker, gitian
Cc: gk, mikeperry Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by isis)

There have been two firefox binaries in TBB for a while, firefox and firefox-bin. Today, while messing around with Selenium for BridgeDB/TBB tests and trying to drive TBB from a sandboxed pypy, I noticed that one of these binaries is now non-stripped. My 3.0.2-alpha's firefox-bin is still there, but stripped, so I assume this was introduced in 3.0.3-alpha to build with the detached debugging symbols. We shouldn't ship a non-stripped binary, even if it's not being used.

I think, to fix this, some changes might need to be made to the gitian-builder to get it to toss out the non-stripped binary, or just not package it.

Child Tickets

Change History (7)

comment:1 Changed 7 years ago by gk

FWIW, the problem started in 3.0a4 and affects other binaries (like plugin-container) as well.

comment:2 Changed 7 years ago by mikeperry

Yes. It looks like we also missed the components/ subdirectory on all platforms, too.

Basically, we need to add another for loop for the .so's in that subdir to strip and objcopy their symbols.

comment:3 Changed 7 years ago by isis

Okay. Got it. Thanks, gk and mikeperry.

Also, FWIW, the windows builds don't have any extra firefox.exe.

comment:4 Changed 7 years ago by isis

Description: modified (diff)
Status: newneeds_review

I already told mikeperry on IRC, but my patches to fix this issue are in this branch. Unfortunately, my git server will only allow you to clone if I've already got your SSH key. You can still view the patches in gitweb otherwise. Sorry. :/

mikeperry already started building a test of it, but found that I missed doing a mkdir -p Browser/components. And mikeperry added the additional binary files that gk pointed out:

08:33 #tor-dev: GeKo) isis: re your fix for 10126: what about "webapprt-stub" or "mozilla-xremote-client" or "updater"...? 
09:17 #tor-dev: GeKo) isis: no problem :) one additional nit "firefix bin" -> "firefox bin" 

And... mikeperry told me not to fix the typo (in my comment in gitian/descriptors/linux/gitian-firefox.yml L94) because he was already testing and it would conflict.

Last edited 7 years ago by isis (previous) (diff)

comment:5 Changed 7 years ago by isis

Description: modified (diff)

comment:6 Changed 7 years ago by mikeperry

Points: 9000
Resolution: fixed
Status: needs_reviewclosed

Ok, this is merged (including the typo fix and the additional files gk pointed out). Thanks isis and gk!

comment:7 Changed 3 years ago by teor

Severity: Normal

Set all tickets without a severity to "Normal"

Note: See TracTickets for help on using tickets.