Opened 6 years ago

Last modified 18 months ago

#10137 new defect

ESR24 won't work without ctypes being enabled

Reported by: gk Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-3.0, tbb-firefox-patch
Cc: Actual Points:
Parent ID: #9809 Points:
Reviewer: Sponsor:

Description

While trying to get a working cross-compiler for ESR24 on Mac OS X we found that Firefox is either crashing right after start-up or highly unusable if it is built with --disable-ctypes (see: comment 69ff. in #9829). Other platforms were not tested, so it might be an OSX only problem although I doubt that.

Child Tickets

Change History (6)

comment:1 Changed 6 years ago by gk

Keywords: tbb-3.0 added

comment:2 Changed 6 years ago by mikeperry

Not sure where you got the branches/commits that had ctypes disabled, but we've had them re-enabled for some time (since TBB 3.0a3 was released). Ctypes is also enabled in the FF24 branches in tor-browser.git:
https://gitweb.torproject.org/tor-browser.git/shortlog/refs/heads/tor-browser-24.1.0esr-1

comment:3 Changed 6 years ago by gk

We learned that enabling ctypes is necessary when getting the cross-compiler to work with vanilla ESR24. This ticket is just a reminder that if we want to disable ctypes we need to patch Firefox, too.

comment:4 Changed 5 years ago by erinn

Keywords: tbb-firefox-patch added

comment:5 Changed 5 years ago by erinn

Component: Firefox Patch IssuesTor Browser
Owner: changed from mikeperry to tbb-team

comment:6 Changed 18 months ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

Note: See TracTickets for help on using tickets.