Opened 6 years ago

Closed 4 years ago

Last modified 3 years ago

#10140 closed defect (fixed)

More locales for Tor Browser Bundle (esp Japanese)

Reported by: mttp Owned by:
Priority: Medium Milestone:
Component: Community/Translations Version:
Severity: Keywords: tbb-usability-localization, TorBrowserTeam201509R
Cc: mikeperry, erinn, gk, Runa, brade, mcs, arthuredelstein, boklm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Someone asked the help desk when the Tor Project expected to release a Japanese Tor Browser Bundle. Runa says we have all the translations we need. Is there any reason we can't make this happen?

Child Tickets

Change History (19)

comment:1 Changed 6 years ago by mikeperry

Cc: gk added; GeKo removed
Keywords: tbb-3.0 added
Summary: Japanese Tor Browser BundleMore locales for Tor Browser Bundle (esp Japanese)

The current list of locales is:
BUNDLE_LOCALES="de es-ES fa fr it ko nl pl pt-PT ru vi zh-CN"

We can add any locales in there that are complete. What else should we add?

comment:2 Changed 6 years ago by mikeperry

The problem here is that the MacOS Firefox locales have a special name. This messes with our current build system, that assumes all locales will be named uniformly for all platforms. Unfortunately, Japanese is the *only* language that deviates from this convention, and only for MacOS: https://ftp.mozilla.org/pub/mozilla.org/firefox/releases/24.2.0esr/mac/

Not sure if this is just a quirk on Mozilla's side, or if it *has* to be this way.

I've gone ahead and added japanese to our extra locales for Torbutton and Tor Launcher, so it should at least be possible to convert other bundles to Japanese a-la the recipie in #10687.

comment:3 Changed 6 years ago by JapanAnon

I am attempting to contact Mozilla about this issue, and hoping we can either change the Firefox naming conventions or find some other workaround that will allow Japanese localization to be included in a future build of the Tor Bundle. Fingers crossed.

comment:4 Changed 4 years ago by mcs

Cc: brade mcs added

comment:5 Changed 4 years ago by arthuredelstein

Cc: arthuredelstein added

comment:6 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201508 tbb-usability-localization added; tbb-3.0 translation l10n tor browser bundle removed

comment:7 Changed 4 years ago by arthuredelstein

One thing we discussed on IRC is that lots of language-specific builds take up lots of space and are slow to copy. This limits the number of languages we support. So I wonder if it might make sense to run builds and also serve the built packages from a VPS, such as Google Compute Engine? Copying should be fairly quick between drives on the same VPS, I would think.

comment:8 Changed 4 years ago by yawning

Note: Discussion specifically regarding Japanese to resume next week (2015/08/16->) with the likely outcome being special casing the OSX locale, since metrics indicates there are a lot of users in Japan.

comment:9 Changed 4 years ago by arthuredelstein

My estimate for building 80 languages (like Mozilla Firefox) for Tor Browser's various platforms would be 40-50 GB per release.

comment:10 Changed 4 years ago by mikeperry

Keywords: TorBrowserTeam201509 added; TorBrowserTeam201508 removed

Move remaining August tickets to September.

comment:11 Changed 4 years ago by yawning

https://github.com/Yawning/tor-browser-bundle/compare/feature10140

Building a set of alpha bundles to test this now, but this *should* do the trick. I'll know in lots of hours.

comment:12 Changed 4 years ago by yawning

I got fucked by some HTTPS-Everywhere bullshit when building the nightly target, and apparently make alpha does not work either. I'm fairly close to rage quitting trying to get test bundles built, but I'm 99% sure all my failures are totally unrelated to the feature branch I'm trying to test.

configure:22954: checking for gtar
configure:22954: checking for tar
configure:22994: checking for wget
configure: error: --enable-tor-browser-update requires --with-tor-browser-version.
*** Fix above errors and then restart with\
               "make -f client.mk build"
make: *** [configure] Error 1

comment:13 Changed 4 years ago by yawning

Status: newneeds_review

Going to just needs_review this since at one point during this whole mess, it did actually appear to download the Japanese stuff that was the problem.

comment:14 Changed 4 years ago by mikeperry

Cc: boklm added
Keywords: TorBrowserTeam201509R added; TorBrowserTeam201509 removed

Thanks Yawning. From that error message, my bet is still on us failing to properly extract a version from the git tags while you were on your custom branch. Someone on the TBB team should be able to take this from here, as your patch seems otherwise fine.

If I'm right about the git tag issue, this may be an issue for boklm to solve.

comment:15 Changed 4 years ago by yawning

#16955 is the ticket I filed with the alpha build failure, with the build log attached. Since I want to have some sort of bundles I can pass around to get the localization checked (and to see if it makes sense myself), I'll try the nightly target with the HTTPSE version from the alpha, and then give up.

comment:16 Changed 4 years ago by yawning

OSX build blew up again due to #16960, but the linux and win32 bundles built fine with my branch. I only bothered to try installing the windows one, but baring the Transifex stuff being a bit old, it is an honest to god Japanese Tor Browser.

I'm rebuilding based off the alpha target now that I know what I was doing wrong, but I expect the build to fully complete. I'll use #10357 for discussions pertaining to the actual translation itself since that's the next step in the process once this is merged.

comment:17 Changed 4 years ago by yawning

make alpha died with this error:

gpg: keyblock resource `../../gitian/gpg/torbrowser.gpg': file open error
gpg: Signature made Tue Aug 11 15:14:23 2015 GMT using RSA key ID D40814E0
gpg: Can't check signature: public key not found
Error: Error checking gpg signature for version 5.5a1
make: *** [incrementals-alpha] Error 1

But my output directory has TorBrowser-5.5a2-osx64_ja-JP-mac.dmg along with 3 million other dmgs, so I am taking it as "Nothing blew up".

comment:18 in reply to:  17 Changed 4 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

Replying to yawning:

make alpha died with this error:

gpg: keyblock resource `../../gitian/gpg/torbrowser.gpg': file open error
gpg: Signature made Tue Aug 11 15:14:23 2015 GMT using RSA key ID D40814E0
gpg: Can't check signature: public key not found
Error: Error checking gpg signature for version 5.5a1
make: *** [incrementals-alpha] Error 1

This is #16973, thanks. I've squashed your branch and applied it to master (commit 5b34c06405a5524a5bc2b8ba42fd0587086dd52c) only (I modified the commit message slightly, adding a bug number etc.). I think it is not too crazy to test a complete new locale in at least one alpha before considering shipping it in the stable series. FWIW: I am not so much worried about a broken bundle as some issue with the release+build process somewhere...

comment:19 Changed 3 years ago by isabela

Component: User Experience/TranslationsCommunity/Translations
Note: See TracTickets for help on using tickets.