omni.ja differs in ESR24 Gitian builds

Testing two builds with the new OS X cross-compiler showed that browser/omni.ja differed. More exactly, only the contents of chrome.manifest showed some reordering.

added MikePerry201311R component::applications/tor bundles/installation ff24-esr owner::erinn parent::10103 priority::medium resolution::fixed status::closed tbb-3.0 tbb-testcase type::defect labels

Trac:
Parent: N/A to #10103 (closed)

Trac:
Owner: #10103 (closed) to erinn
Status: new to assigned

Trac:
Status: assigned to new

Trac:
omnidiff

I investigated the omni.ja packaging step and nothing jumped out at me that could explain the diff in the omnidiff attachment. Thus, I run 20 package tests on Linux and 20 on Mac and they produced always the same omni.ja. My new idea is that the step generating the browser.manifest which in turn gets merged into the problematic chrome.manifest during omni.ja packaging is the culprit here. Looking into that now.

Yes. I ran two builds on my test Mac and they produced different browser.manifest files.

Hmm, running JarMaker.py two hundred times did not help in reproducing the problem. Seems there is still more to it.

Okay. Just rebuilding the browser part does already trigger the problem. This takes much less than a minute and I can start debugging this seriously. The other option that is helping us is building with -j1 (according to Mike Hommey) which I'd avoid if I could.

Trac:
0001-bug-10159-making-the-manifest-files-deterministic-by.patch

Finally, after a lot of pain...

Trac:
Status: new to needs_review

Trac:
Keywords: N/A deleted, MikePerry201311R added

Ok. Merged as a fixup commit in tor-browser-24.1.1esr-1.

Do we also want the javascript patch from https://bugzilla.mozilla.org/show_bug.cgi?id=943331#c4, too? Reopen and make sure this is re-tagged to be on my radar if so.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

Replying to mikeperry:

Ok. Merged as a fixup commit in tor-browser-24.1.1esr-1.

Do we also want the javascript patch from https://bugzilla.mozilla.org/show_bug.cgi?id=943331#c4, too?

Yes, in #10235 (closed). I'll attach a patch shortly.

Trac:
Keywords: N/A deleted, tbb-testcase added

closed

mentioned in issue #12620 (moved)