Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#10189 closed defect (fixed)

Torbutton's "Test Settings" fails with "No TorCheckResult id found (response not valid XHTML)"

Reported by: arma Owned by: mikeperry
Priority: Medium Milestone:
Component: TorBrowserButton Version:
Severity: Keywords: tbb-3.0
Cc: arlolra Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When you go to Torbutton Preferences and click "Test Settings", it complains that No TorCheckResult id found.

What's going on inside Torbutton to make this happen?

Confirmed in both TBB 3.0b1 (by me) and 2.4.18-rc-1 (by Erinn).

Child Tickets

Change History (8)

comment:2 Changed 7 years ago by gk

The error console says:

Timestamp: 19.11.2013 07:53:35
Error: syntax error
Source File: https://check.torproject.org/?TorButton=true
Line: 1, Column: 1
Source Code:
<!doctype html>

comment:3 Changed 7 years ago by poncho

This issue breaks the about:tor page in case the control port is missing.

I've tried to use torbrowser 3.0rc1 with the system wide installed tor (and therefore with the tor-launcher extension disabled)

Everything works fine although the about:tor page reports that tor isn't working (in fact, it is working...)

This is because torbutton uses https://check.torproject.org/?TorButton=true as a fallback if the control port is missing.
https://gitweb.torproject.org/torbutton.git/commit/c48bf013150c6a5cd0bfc17cf219615824208f44

comment:4 Changed 7 years ago by arma

Cc: arlolra added

Arlo, did the earlier version of Tor Check answer something at this url?

It sure seems undocumented, but maybe the best fix is to fix it on the Check side.

comment:5 Changed 7 years ago by arma

(See also #10216)

comment:6 in reply to:  4 Changed 7 years ago by arlolra

Replying to arma:

Arlo, did the earlier version of Tor Check answer something at this url?

Yes, and I made sure to add it. You can visit,

view-source:https://check.torproject.org/?TorButton=true

I think the problem is as gk noted above,

The error console says:

Error: syntax error
Source Code:
<!doctype html>

It doesn't like the html5 doctype. Maybe it needs an older,

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">

comment:8 Changed 7 years ago by arma

Yay. Confirmed that the fix works for my TBB.

Note: See TracTickets for help on using tickets.