Opened 7 years ago

Closed 5 years ago

Last modified 5 years ago

#10216 closed enhancement (fixed)

Add a Torbutton pref to disable the Tor check

Reported by: T(A)ILS developers Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-torbutton, TorBrowserTeam201503R, AffectsTails
Cc: mikeperry Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


The test_enabled_pref branch on git:// adds a test_enabled pref, that allows one to entirely disable the Tor check feature. Please consider merging into Torbutton.

Since the new was put online, the remote check fails for us (the browser console reports Torbutton WARN: Test failed! No TorCheckResult element), and I don't find it important enough to bother fixing the backend (or the set of ugly kludges we were using to workaround bugs and have the Tor check work while disabling the version check): even if the proxy settings were wrong, we still have the firewall to prevent going out in the clear, and we would have to customize about:tor to make it useful for Tails users without bothering Tor support folks.

Child Tickets

Change History (11)

comment:1 Changed 7 years ago by arma

See also #10189.

comment:2 Changed 7 years ago by arma

What does the #10189 fix do to the state of this ticket?

comment:3 Changed 6 years ago by erinn

Component: TorBrowserButtonTor Browser
Keywords: tbb-torbutton added
Owner: changed from mikeperry to tbb-team

comment:4 in reply to:  2 Changed 6 years ago by anonym

Replying to arma:

What does the #10189 fix do to the state of this ticket?

Sorry for the late answer, but no, it doesn't fix the issue we experience in Tails.

comment:5 Changed 5 years ago by intrigeri

Cc: mikeperry added

Rebased the proposed branch on top of current master. For the record, we're still shipping this patch (against in current Tails, and also (against in our feature/torbrowser-alpha branch that currently installs Tor Browser 4.5a4. Works fine for us in both cases.

My understanding is that Torbutton will be replaced by C++ patches soonish, and surely we don't want to have to patch Tor Browser ourselves, so it would be good if the Tails use case was supported before the porting work is done, so that the port to C++ supports it as well :)

(Explicitly Cc'ing Mike, since iirc the Tor Browser team doesn't track Torbutton tickets anymore.)

comment:6 Changed 5 years ago by gk

Is this ready for review? Or do you need feedback, or...? This is no Torbutton ticket btw, but a Tor Browser one, so everything is okay. ;)

comment:7 Changed 5 years ago by intrigeri

Status: newneeds_review

IMO it's ready for a Torbutton developer to have a look at it, and then either just review'n'merge if good enough, or tell us how it's broken and should be improved.

comment:8 Changed 5 years ago by gk

Keywords: TorBrowserTeam201503R added

comment:9 Changed 5 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Looks simple enough, and doesn't impact how TBB behaves at all. If this works for Tails already, it's fine with me. Merged.

comment:10 Changed 5 years ago by gk

Just for the record: You probably wanted m_tb_prefs and not m.tb_prefs as the latter is undefined. The fixup is in commit 54d02f3c1c97c2dcef2c8c03bc00580592a6cf38.

I wonder how this ever worked in Tails, though.

comment:11 Changed 5 years ago by cypherpunks

Keywords: AffectsTails added
Note: See TracTickets for help on using tickets.