Opened 10 years ago

Last modified 7 years ago

#1022 closed defect (Fixed)

eventdns setting truncated bit wrong?

Reported by: arma Owned by: nickm
Priority: Low Milestone:
Component: Core Tor/Tor Version: 0.2.0.34
Severity: Keywords:
Cc: arma, karsten, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

<optimist> eventdns.c "buf[3] |= 0x02; /* set the truncated bit. */". why it
is buf[3]? isn't should be buf[2]?

»·······APPEND16(req->trans_id);
»·······APPEND16(flags);
»·······»·······buf[3] |= 0x02; /* set the truncated bit. */
i haven't looked much yet. but perhaps the truncated bit is in the second

byte of flags?

where are the possible flags listed? how horrible

optimist> in first, for network order, so it [2]. I think
optimist> flags placed in [2] and [3]

if this is a bug, what problems would it make?

optimist> it rewrites actual RCODE - Response code

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (3)

comment:1 Changed 10 years ago by nickm

fixed; thanks!

(Impact is low, since we never actually generate big evdns replies.)

comment:2 Changed 10 years ago by nickm

flyspray2trac: bug closed.

comment:3 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.