Opened 10 years ago

Last modified 7 years ago

#1023 closed defect (Fixed)

Authorities should avoid voting on Running if they just came up

Reported by: arma Owned by:
Priority: Low Milestone: post 0.2.1.x
Component: Core Tor/Tor Version: 0.2.0.33
Severity: Keywords:
Cc: arma, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

the reason this came up is when an authority comes up near to voting time,
it ends all the uptimes in its router-stability file, because it votes 'no'
on all of them, and the act of deciding its vote changes the router-stability
line.

<nickm> Proposed other behavior: If we have been up less than N minutes, don't
vote on Running. For N == 30? 45?

30 should be fine

<nickm> We'd probably want this to be overridable for test networks, alas.

hey, we have a config option for that.

V(TestingTorNetwork, BOOL, "0"),

which could override it automatically

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (1)

0001-Don-t-set-unreachable-from-dirvote-unless-we-ve-been.patch (2.6 KB) - added by nickm 10 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 10 years ago by nickm

Hm. We already have a notion of this: check out the vote_on_reachability variable in
dirserv_generate_networkstatus_vote_obj(). It determines whether we vote for Running at all. It depends on
TestingAuthDirTimeToLearnReachability, which defaults to 30 min, or 0 minutes if TestingTorNetwork is true.

So there seem to be two issues here, actually:

  • Even though we don't vote on Running, we still calculate what the vote would be, which alter our notion of up/down.
  • We still need to list Running anyway when we make a v2 vote.

Suggestion: we should alter dirserv_set_router_is_reachable() to only call rep_hist_note_router_unreachable() when
we have been running for at least TestingAuthDirTimeToLearnReachability seconds. Would this suffice?

comment:2 Changed 10 years ago by nickm

Possible fix in bug1023 branch of my public repo. Reproduced in attachment.

comment:3 Changed 10 years ago by nickm

Should be fixed by 5a6575c2d42c891965cc7639d212cb860f698bd2

comment:4 Changed 10 years ago by nickm

flyspray2trac: bug closed.

comment:5 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.