Opened 6 years ago

Closed 6 years ago

#10241 closed defect (fixed)

bunch of ruleset bugs

Reported by: cypherpunks Owned by: pde
Priority: Medium Milestone:
Component: HTTPS Everywhere/HTTPS Everywhere: Chrome Version:
Severity: Keywords:
Cc: dev.akhawe+tor@… Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This is based on the ruleset in the Chrome extension based on a recent git checkout.

<rule from="http://(leap3\.|www\.)?singlehop\.com/" to="https://$1.singlehop.com/"/>

the to rule should not have a dot (or move the dot outside the capture)

--

<rule from="^http://(?:www\.)?mystockoptions\.com/" to="https://$1mystockoptions.com/"/>

the group should be capturing for $1 to work (www\.)

---

<rule from="^http://(www\.)?tunisia-sat\.com(\.tn)?/" to="https://$1tunisia-sat.com$1/"/>

The last part should be $2


<rule from="^http://(www\.)?vn5socks\.com/" to="https://$1.vn5socks.com/"/>

No dot in the replacement since $1 already captures the dot

---

Child Tickets

Change History (2)

comment:1 Changed 6 years ago by zyan

Thanks! Opened a pull request here: https://github.com/pde/https-everywhere/pull/8

One slight modification: mystockoptions.com only has a valid cert for www*, so I changed it to:
<rule from="http://(?:www\.)?mystockoptions\.com/" to="​https://www.mystockoptions.com/"/>

comment:2 Changed 6 years ago by zyan

Resolution: fixed
Status: newclosed
Note: See TracTickets for help on using tickets.