Opened 6 years ago

Closed 6 years ago

#10252 closed defect (fixed)

TBB based on ESR 24 is not working on Windows

Reported by: gk Owned by:
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords: ff24-esr, tbb-3.0
Cc: Actual Points:
Parent ID: #10103 Points:
Reviewer: Sponsor:

Description

Testing the patches in #9830 shows that TBB is starting but nothing happens and after a while the process is not visible on the Task Manager anymore.

Child Tickets

Attachments (1)

0001-Bug-10252-backout-of-Mozilla-s-872649-as-this-breaks.patch (1.6 KB) - added by gk 6 years ago.

Download all attachments as: .zip

Change History (6)

comment:1 Changed 6 years ago by gk

Testing with an old revision of tor-browser-bundle (one that does not contain the fix for #9084) works fine. Thus, it might be the case that we need to adapt the fix developed there to ESR24.

Backing out https://bugzilla.mozilla.org/show_bug.cgi?id=831707 and https://bugzilla.mozilla.org/show_bug.cgi?id=876416 was my first idea but did not help. Let's start some bisecting session then...

comment:2 Changed 6 years ago by gk

Summary: TBB based on ESR 24 is not starting on WindowsTBB based on ESR 24 is not working on Windows

comment:3 Changed 6 years ago by gk

The short version is: https://bugzilla.mozilla.org/show_bug.cgi?id=872649 is the culprit. It is probably easiest to just back it out. The impact for our supported OSes should be zero as the Mozilla bugfix is only relevant for ARM platforms. A test build with #872649 backed out can be found on:
https://people.torproject.org/~gk/testbuilds/torbrowser-install-3.5-alpha-1pre_en-US.exe
Signature:
https://people.torproject.org/~gk/testbuilds/torbrowser-install-3.5-alpha-1pre_en-US.exe.asc

comment:4 Changed 6 years ago by gk

Status: newneeds_review

Added a patch for review (should have been a branch on my tor-browser repo but for some reason pushing/retrieving via SSH is not working yet...).

comment:5 Changed 6 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

This is implemented.

Note: See TracTickets for help on using tickets.