Opened 6 years ago

Closed 5 years ago

#10319 closed enhancement (fixed)

Reimplement cache isolation as a direct C++ patch

Reported by: mikeperry Owned by:
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-linkability, interview, tbb-firefox-patch
Cc: gk, mcs, brade Actual Points:
Parent ID: #6528 Points:
Reviewer: Sponsor:

Description

Our current cache isolation relies on a cacheKey hack to isolate the content cache per domain. This requires an on-modify-request observer in javascript that could be done in C++ instead.

We should implement something that sets this property directly in C++. Or perhaps we should see if we can leverage the new concurrent Private Browsing mode code to isolate both the image and content cache with much less complexity than our current patches.

Child Tickets

Change History (7)

comment:1 Changed 6 years ago by mikeperry

See also #8167 for some related issues with the current content cache implementation, especially issues with dealing with OCSP and other non-windowed urls.

Also see https://bugzilla.mozilla.org/show_bug.cgi?id=878890, which has to similarly deal with these same windowless URLs. We may be able to re-use some of its detection logic for them.

comment:2 Changed 6 years ago by gk

Cc: gk added

comment:3 Changed 6 years ago by mcs

Cc: mcs brade added

comment:4 Changed 6 years ago by mikeperry

Keywords: interview added

comment:5 Changed 5 years ago by erinn

Keywords: tbb-firefox-patch added

comment:6 Changed 5 years ago by erinn

Component: Firefox Patch IssuesTor Browser

comment:7 Changed 5 years ago by gk

Resolution: fixed
Status: newclosed

This got done in #13742.

Note: See TracTickets for help on using tickets.