Opened 6 years ago

Closed 2 years ago

#10369 closed defect (fixed)

Building the Utils component in OS X TBBs is broken with the new cross-compiler

Reported by: gk Owned by: gk
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: gitian, tbb-3.0, tbb-gitian, GeorgKoppen201703, TorBrowserTeam201704R
Cc: mcs, brade, tom@… Actual Points:
Parent ID: #21328 Points:
Reviewer: Sponsor:

Description (last modified by gk)

At least in order to ship 64bit OS X bundles we need to switch the compiler on OS X to our new cross-compiler. Moreover, as we do not ship the old one users can't build the OS X bundles themselves out-of-the-box anymore currently.

Child Tickets

Change History (20)

comment:1 Changed 6 years ago by gk

Note: We don't ship the gcc toolchain anymore. Thus, until this bug is fixed users can't build the Mac OS X bundles themselves if they don't have the old toolchain in gitian-builder/inputs already.

comment:2 Changed 6 years ago by gk

Keywords: gitian added

comment:3 Changed 6 years ago by gk

Priority: normalmajor

comment:4 Changed 6 years ago by gk

Description: modified (diff)
Summary: Use the new OS X cross-compiler for building the Tor component in TBBsBuilding the Tor component in OS X TBBs is broken with the new cross-compiler
Type: enhancementdefect

comment:5 Changed 6 years ago by mcs

Cc: mcs brade added

comment:6 Changed 6 years ago by gk

Keywords: MikePerry201403 added

comment:7 Changed 6 years ago by mikeperry

OpenSSL does not like this new compiler. It expects cc to take the -arch flag, and even if I cut that bit out, the new compiler dies on the assembly in x86cpuid.s.

I committed a fix to master to resume downloading the old compiler. You can see my branch to attempt to switch tor and PT to the new one in mikeperry/bug10369, but that breaks on OpenSSL compilation as I said.

comment:8 Changed 6 years ago by gk

We are using clang for cross-compiling the browser. So the aim is, I'd say, to use clang for the tor component (including the libraries it depends on) as well. And IIRC the gcc stuff is not going to work.

comment:9 Changed 5 years ago by mikeperry

Keywords: MikePerry201403 removed

comment:10 Changed 5 years ago by erinn

Component: Tor bundles/installationTor Browser
Keywords: tbb-gitian added

comment:11 Changed 5 years ago by tom

Cc: tom@… added

comment:12 Changed 5 years ago by mikeperry

Parent ID: #10138

Deparenting this as it is independent of 64bit builds.

comment:13 Changed 4 years ago by gk

Keywords: GeorgKoppen201506 added
Owner: set to gk
Status: newassigned

comment:14 Changed 3 years ago by gk

Severity: Normal
Summary: Building the Tor component in OS X TBBs is broken with the new cross-compilerBuilding the Utils component in OS X TBBs is broken with the new cross-compiler

comment:15 Changed 3 years ago by gk

Keywords: GeorgKoppen201703 TorBrowserTeam201703R added; GeorgKoppen201506 removed
Parent ID: #21328

Finally, this is ready for review. See bug_10369_v2 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_10369_v2&id=e0b570f34528453ff9d7c25c7200c86d5261c710) in my public tor-browser-bundle repo.

comment:16 Changed 3 years ago by gk

Status: assignedneeds_review

comment:17 Changed 3 years ago by gk

Okay, the final one from my side: bug_10369_v5 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_10369_v5&id=b73ae0f7fcd60e979d8651da81c5c947616d5514) It includes some comment updates and does not extract our build tools into $INSTDIR.

comment:18 Changed 2 years ago by boklm

The patch for this included in branch gk/bug_21328_v4 looks good to me.

comment:19 Changed 2 years ago by gk

Keywords: TorBrowserTeam201704R added; TorBrowserTeam201703R removed

Moving review tickets to April.

comment:20 Changed 2 years ago by gk

Resolution: fixed
Status: needs_reviewclosed

This is commit e32cc7890a13d1707e9f3109fd8e888ac8623537 on master.

Note: See TracTickets for help on using tickets.