Opened 7 years ago

Closed 6 years ago

#10384 closed defect (fixed)

TorLauncher UI seems to split bridge fingerprints onto a new line

Reported by: isis Owned by: brade
Priority: Medium Milestone:
Component: Applications/Tor Launcher Version:
Severity: Keywords: tbb-usability-stoppoint-wizard, tbb-easy, tbb-4.5-alpha, TorBrowserTeam201504
Cc: isis, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


When entering a bridge IP:port and fingerprint into the TorLauncher firstrun wizard, if IP:port fingerprint is entered, when I press Return TorLauncher seems to split the fingerprint onto its own separate line.

Functionally, TorLauncher is working with bridge fingerprints just fine. Checking the line in the torrc, the bridge's fingerprint is on the correct torrc line along with the bridge's address and port. However, the split-second glitch in the UI had me worried for a second that the fingerprint was not going into tor properly and wouldn't be checked, and at this point tor was already connecting. I'm not sure how likely this behaviour would be to scare users, but I thought I'd better open a ticket for it regardless.

Child Tickets

Change History (5)

comment:1 Changed 7 years ago by mcs

Cc: mcs added

Is it wrapping the text or inserting a new line?

Note that Tor Launcher adds "bridge" in front of what you enter to be consistent with torrc.

comment:2 Changed 7 years ago by mikeperry

Keywords: tbb-usability tbb-easy added; ui removed
Priority: trivialnormal

This sounds like the UI is just splitting the line. I sounds like Isis verified the torrc actually got the full and correct bridge line, based on what she wrote in the description.

comment:3 Changed 6 years ago by karsten

GeKo suggested this ticket for the easy-tasks section in Tor Weekly News.

What's the suggested fix here? Enable both vertical and horizontal scroll bars? And would it make sense to change the grayed-out text from "type address:port" to "type address:port [fingerprint]" or something else that implies that fingerprints are okay to enter?

Also, how would a new contributor start hacking on the UI? Is there a document or two that they can read to get started?

comment:4 Changed 6 years ago by mikeperry

Keywords: tbb-usability-stoppoint-wizard added; tbb-usability removed

comment:5 Changed 6 years ago by mcs

Keywords: tbb-4.5-alpha TorBrowserTeam201504 added
Resolution: fixed
Status: newclosed

This was fixed as part of the commit for #13576.

Note: See TracTickets for help on using tickets.