Opened 6 years ago

Closed 6 years ago

#10387 closed defect (fixed)

Buildling PTTBB requires $PYTHONHOME

Reported by: ln5 Owned by: dcf
Priority: Medium Milestone:
Component: Applications/Tor bundles/installation Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Tried building TBB alpha with PT from https://git.torproject.org/user/dcf/tor-browser-bundle.git, branch 'pt'. It seems like makexpi.sh needs $PYTHONHOME:

+ mv ../torbutton@torproject.org.xpi '../../../tbb-windows-installer/Tor Browser/Data/Browser/profile.default/extensions/torbutton@torproject.org.xpi'
+ cd ../../../
+ cd https-everywhere
+ rm -f .git/refs/heads/master
+ ./makexpi.sh
Could not find platform independent libraries <prefix>
Could not find platform dependent libraries <exec_prefix>
Consider setting $PYTHONHOME to <prefix>[:<exec_prefix>]
ImportError: No module named site
ERROR: Validation of rulesets failed.

Child Tickets

Change History (3)

comment:1 Changed 6 years ago by dcf

That's strange. I don't even know what makexpi.sh is. I didn't have to touch it.

The pt branch's gitian-bundle.yml isn't very different from master's, so I don't think that's it.

$ git diff -U1 master -- descriptors/windows/gitian-bundle.yml
diff --git a/gitian/descriptors/windows/gitian-bundle.yml b/gitian/descriptors/windows/gitian-bundle.yml
index f56c15d..dc8f1ea 100644
--- a/gitian/descriptors/windows/gitian-bundle.yml
+++ b/gitian/descriptors/windows/gitian-bundle.yml
@@ -27,2 +27,3 @@ files:
 - "tor-win32-gbuilt.zip"
+- "pluggable-transports-win32-gbuilt.zip"
 - "relativelink-src.zip"
@@ -36,2 +37,3 @@ files:
 - "tbb-docs.zip"
+- "pttbb-docs.zip"
 script: |
@@ -101,4 +103,7 @@ script: |
   unzip ~/build/tor-win32-gbuilt.zip
+  unzip ~/build/pluggable-transports-win32-gbuilt.zip
   unzip ~/build/windows-skeleton.zip
   unzip ~/build/tbb-docs.zip
+  mkdir -p Docs/PluggableTransports
+  unzip -d Docs/PluggableTransports ~/build/pttbb-docs.zip
   cd ..

What if you add python to the "packages" of gitian-bundle.yml? python seems to be needed for makexpi.sh, and if you started with just the bundle descriptor, it might not have been previously incidentally installed.

comment:2 Changed 6 years ago by dcf

Status: newneeds_review

I think this problem exists also in the main tor-browser-bundle repo, and is not related to pluggable transports. But I suppose it is fixed by ca30dd31.

comment:3 Changed 6 years ago by dcf

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.