Opened 7 years ago

Last modified 10 months ago

#10388 new defect

TBB should disable "New Private Window" menu option if disk history is disabled

Reported by: mikeperry Owned by: tbb-team
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-usability, tbb-firefox-patch
Cc: wiretapped, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:


Because we use browser.privatebrowsing.autostart as defense in depth against disk leaks, "New Private Window" is equivalent to "New Window". This can be confusing to users who will expect their "New Private Windows" to be isolated from their normal TBB state, especially since the UI hints are different for these windows.

We should probably patch Firefox to hide this menu option if browser.privatebrowsing.autostart is set. This seems like something Mozilla should be interested in picking up.

Child Tickets

Change History (4)

comment:1 Changed 6 years ago by erinn

Keywords: tbb-firefox-patch added

comment:2 Changed 6 years ago by erinn

Component: Firefox Patch IssuesTor Browser
Owner: changed from mikeperry to tbb-team

comment:3 Changed 3 years ago by teor

Severity: Normal

Set all open tickets without a severity to "Normal"

comment:4 Changed 10 months ago by gk

We already remove that item from the hamburger menu (not sure where exactly but I guess in 46d4ce493b8a90adec9d8d8e96393248d6565d4b). What is missing is the file menu and the customization window.

Oh, and, yes we should make sure all the options are visible again in case the user enables disk history.

Note: See TracTickets for help on using tickets.