Opened 5 years ago

Last modified 23 months ago

#10426 new defect

"new identity" button causes in-progress downloads to be aborted

Reported by: cypherpunks Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Normal Keywords: tbb-3.0, tbb-usability, tbb-newnym, tbb-easy, tbb-torbutton
Cc: gk, Rola, mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

I recently upgraded my Tor Browser Bundle from the previous stable 2.5.x series to 3.5 rc1.

It seems the behavior of the Torbutton menu "new identity" command has change. Previously, if a download was in progress (using the Firefox download manager), it continued unaffected (using the old circuit, presumably) after "new identity" had been clicked.

In 3.5 rc1, any in-progress downloads are aborted if you click "new identity".

I preferred the old behavior. In the new version, the user is forced to wait until any downloads have completed before switching to a new identity. Users may be tempted to continue using an old identity in situations where this might compromise their anonymity, so as to allow a download to complete.

Child Tickets

Change History (10)

comment:1 Changed 5 years ago by gk

Cc: gk added
Keywords: tbb-3.0 added
Version: Tor: unspecified

comment:2 Changed 5 years ago by gk

Keywords: tbb-usability added

comment:3 Changed 5 years ago by gk

Keywords: tbb-newnym added

comment:4 Changed 5 years ago by eros_nm

I do support cipherpunks ticket. Please consider to add a feature for multiple identity downloads. There are still a lot of other possibilities, like flash plugins, where user can take security risks at their own request.

comment:5 Changed 5 years ago by mikeperry

Keywords: tbb-easy added

This could be an about:config pref, I suppose. It seems like something I want to avoid adding UI for though.

comment:6 Changed 4 years ago by erinn

Component: TorBrowserButtonTor Browser
Keywords: tbb-torbutton added
Owner: changed from mikeperry to tbb-team

comment:7 Changed 4 years ago by gk

Cc: Rola added

From #14423 which suggests we should give the user some hint/options here:

 Could TorButton check whether a download is in progress and, if so, give the user a choice whether to proceed?

It currently seems to be assumed that cancelling & clearing the download is acceptable. It doesn't provide any feedback to the user about this assumption either - their downloads just disappear.

As a simple fix, couldn't we just present a popup and clear this behavour with the user before creating the new identity?

"Choosing a new identity at this time will cancel your current downloads. Do you want to proceed?"

comment:8 Changed 4 years ago by mcs

Cc: mcs added

comment:9 Changed 23 months ago by cypherpunks

Severity: Normal

Would it be possible to reuse the warning prompt that Firefox already provides when you attempt to quit when a download is in progress?

comment:10 in reply to:  9 Changed 23 months ago by mcs

Replying to cypherpunks:

Would it be possible to reuse the warning prompt that Firefox already provides when you attempt to quit when a download is in progress?

I think the text used for that prompt is too focused on "Quit" or "Exit". Firefox already has several variations of the text (quit, offline, leave private browsing mode), so adding another one seems like the best approach. Existing text may be found here:

https://dxr.mozilla.org/mozilla-esr45/source/toolkit/locales/en-US/chrome/mozapps/downloads/downloads.properties#25

The real work is to patch the Firefox code here to handle the New Identity case or to implement a similar prompt in Torbutton:

https://dxr.mozilla.org/mozilla-esr45/source/toolkit/components/downloads/nsDownloadManager.cpp#2454

Note: See TracTickets for help on using tickets.