Opened 7 years ago

Closed 7 years ago

#10485 closed defect (fixed)

Heartbeat doesn't include 'circuit stats since last time'

Reported by: cypherpunks Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version: Tor: 0.2.4.19
Severity: Keywords: tor-client 024-backport easy
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

This message is shown every 30 minutes, as per my HeartbeatPeriod.

[NOTICE] Heartbeat: Tor's uptime is xxx hours, with xxx circuits open. I've sent xxx and received xxx GB.

This message is not (and I don't know how to control how frequently it is shown).

[NOTICE] Circuit handshake stats since last time: x/x TAP, x/x NTor.

How can I make the latter message as frequent/infrequent as I like? Can it be merged into the HeartbeatPeriod?

Child Tickets

Change History (5)

comment:1 Changed 7 years ago by nickm

Keywords: tor-client 024-backport easy added
Milestone: Tor: 0.2.4.x-final

This is an easy fix: we just move the rep_hist_log_circuit_stats into the heartbeat message from main.c.

I've done this in master with 2b8962bc64852d601efa2a8a624bffbbf5ba7ef5, and I have a branch to do it sitting in my "bug10485" branch for possible backport into 0.2.4. Shall we backport?

(And Roger, do you remember why bridges don't do this?)

comment:2 in reply to:  1 Changed 7 years ago by arma

Replying to nickm:

(And Roger, do you remember why bridges don't do this?)

    if (connection_or_digest_is_known_relay(chan->identity_digest))
      rep_hist_note_circuit_handshake_requested(create_cell->handshake_type);

They don't count it if the request came from a client. That's bad because it undercounts, but also good because I didn't have to wonder what the privacy implications were of keeping and publishing this stuff (especially if we ever move forward with the plans of putting these numbers in extrainfo descriptors).

So it's pretty pointless for bridges to collect the stats, since hopefully they won't count anything.

See also #9658 which seems related to this ticket towards the end.

comment:3 Changed 7 years ago by nickm

Status: newneeds_review

Okay, I did the obvious trivial patch in bug10485_024. Please review nice and quick?

comment:4 Changed 7 years ago by nickm

Roger thought it looked okay; merged it. (Looks like we already merged something similar into 0.2.5. Whoops.

comment:5 Changed 7 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.