Opened 10 years ago

Closed 3 years ago

#1053 closed defect (invalid)

TypeError: browser is undefined

Reported by: chiavibianci Owned by:
Priority: High Milestone:
Component: Applications/Torbutton Version: Torbutton: 1.2.1
Severity: Normal Keywords:
Cc: chiavibianci Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Torbutton displays 'Tor disabled' in red even though Tor/privoxy are running.
(Vidalia shows a green onion in the task bar, netstat -a shows privoxy listening on 127.0.0.1:9050)

Clicking on the red text does nothing - no feedback.
Selecting 'Preferences...->Test settings' pops up a dialog box saying

---
Torbutton: Please file bug report! Error applying Tor settings: TypeError: browser is undefined
---

followed by another

---
Tor proxy test FAILED! Check your proxy and Privoxy settings.
---

OS: ubuntu 9.04 jaunty x86 desktop inside virtualbox 3.0.2 r49928
Firefox: 3.5.2 installed with ubuntuzilla.py 4.7.2-0ubuntu1 synaptic package manager
Tor: 0.2.1.19-1~jaunty+1 from noreply.org synaptic package manager
Vidalia: 0.1.9-3 synaptic package manager
Torbutton: 1.2.1 added within Firefox as xpi
Other Firefox addons: NoScript 1.9.7.9, RefControl 0.8.11
Browser string in About box: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.7) Gecko/2009021910 Firefox/3.0.7

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (3)

torbutton-1.2.3-pre2.xpi (313.0 KB) - added by mikeperry 10 years ago.
torbutton-1.2.3-pre3.xpi (343.5 KB) - added by mikeperry 10 years ago.
torbutton-1.2.3-pre4.xpi (341.0 KB) - added by mikeperry 10 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 10 years ago by chiavibianci

should add that, after resetting general.useragent.override in about:config, the useragent string
reverts back to the unmasked string

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2

comment:2 Changed 10 years ago by mikeperry

Do you have any custom Tor settings? Nick just tested this on Mac OS with Firefox 3.5.2 and it was successful.

Does the problem still happen if you create a new fresh firefox profile with just Torbutton? You can launch
a new firefox with a profile selection+creation window with firefox -P -no-remote.

If it doesn't happen with the plain profile, we'll need to try to narrow down to the pref that causes
the error.

comment:3 Changed 10 years ago by chiavibianci

no, I don't have any custom Tor settings. This is a new ubuntu 9.04 installation with
entirely default settings - only hours old.

What I see in the error log is

---E
Error: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: file:///home/xxxxxxx/.mozilla/firefox/xxxxxxxx.default/extensions/%7Be0204bd5-9d31-402b-a99d-a6aa8ffebdca%7D/components/nsSessionStore3.js :: <TOP_LEVEL> :: line 111" data: no]
---

and

---W
Failed to load XPCOM component: /home/xxxxxxx/.mozilla/firefox/xxxxxxx.default/extensions/{e0204bd5-9d31-402b-a99d-a6aa8ffebdca}/components/nsSessionStore3.js
---

and some JS rewrite info for the function torbutton_update_tags() - that's all

(why is torbutton patching one of its own functions ?)

I uninstalled RefControl 0.8.11 - no change
I uninstalled NoScript 1.9.7.9 - no change

I then followed your instructions and started firefox as the logged in non-root user
from a terminal with the command line

firefox -P -no-remote

created a new profile and installed torbutton as the first and only add-on using
the internal xpi add-on mechanism to get 1.2.1 and restarted in this new profile.

Torbutton now immediately turns green on first click, but fails as before if I do
a 'test settings' from the Preferences dialog box. That may be another level of
Ubuntu crap-ness about my new Tor/Privoxy default install, I don't know. As I say,
this is a new install and I've haven't got this working yet as it fails OOTB.

The same error messages as before are still present in the console log

---E
Error: uncaught exception: [Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: file:///home/xxxxxxxx/.mozilla/firefox/xxxxxxx.torbuttontest/extensions/%7Be0204bd5-9d31-402b-a99d-a6aa8ffebdca%7D/components/nsSessionStore3.js :: <TOP_LEVEL> :: line 111" data: no]
---

---W
Failed to load XPCOM component: /home/xxxxxx/.mozilla/firefox/xxxxxxx.torbuttontest/extensions/{e0204bd5-9d31-402b-a99d-a6aa8ffebdca}/components/nsSessionStore3.js
---

The output from the terminal is

---
xxxxx@uxxxxx:~$ firefox -P -no-remote
Torbutton logger online
[08-09 14:43:24] Torbutton NOTE: Skipping no location: chrome://browser/content/browser.xul
[08-09 14:43:26] Torbutton NOTE: First time startup completed
[08-09 14:43:26] Torbutton NOTE: Restoring tor state
[08-09 14:43:55] Torbutton NOTE: Some other addond tried to clear user agent settings.
[08-09 14:50:52] Torbutton WARN: Tor test failed!
xxxxx@xxxxx:~$
---

odd -[08-09 14:43:55] - there are no other extensions.

comment:4 Changed 10 years ago by aide

Torbutton: Please file bug report! Error applying Tor settings: TypeError: browser is undefined

Ff 3.5.2
Torbutton 1.2.2

to reproduce:
firefox -ProfileManager
New profile
Install Torbutton
restart Ff
Configure:http://img176.yfrog.com/i/tbp.png/
Restart Ff
Torbutton preferences "Restore Defaults"

comment:5 Changed 10 years ago by mikeperry

Do either of you happen to have the setting "Close all Tor tabs on toggle" set under dynamic content?
If so, could you try the xpi attached in the attachment tab and see if it fixes it?

Otherwise, I'm not sure exactly where this undefined browser error is coming from. Is that always the
error?

Changed 10 years ago by mikeperry

Attachment: torbutton-1.2.3-pre2.xpi added

comment:6 Changed 10 years ago by mikeperry

Actually that XPI will probably not fix it. I'm still trying to get to the bottom of that close all tabs setting bug
(if that is even your problem).

comment:7 Changed 10 years ago by mikeperry

Ok, there's a new one in the attachments tab. If you could try that, it *may* fix it, but probably I will have to
put up another one with some log messages in the various places this could be happening.

Changed 10 years ago by mikeperry

Attachment: torbutton-1.2.3-pre3.xpi added

comment:8 Changed 10 years ago by mikeperry

Ok, got the log messages in. Is anyone still watching this bug? It will be the 1.2.3-pre4 attachment in the
attachments tab. Try it. It should allow you to toggle, but should now put out a warn in the
javascript error console. Please paste that warn here.

Changed 10 years ago by mikeperry

Attachment: torbutton-1.2.3-pre4.xpi added

comment:9 Changed 9 years ago by erinn

Version: 1.2.1Torbutton: 1.2.1

Updating the version from 1.2.1 to Torbutton: 1.2.1 so I can close #1743.

comment:10 Changed 3 years ago by bugzilla

Resolution: Noneinvalid
Severity: Normal
Status: newclosed

Torbutton is dead.

Note: See TracTickets for help on using tickets.