Opened 6 years ago

Closed 6 years ago

#10559 closed defect (fixed)

BridgeDB writes `keyid=` before fingerprints

Reported by: isis Owned by: isis
Priority: Medium Milestone:
Component: Circumvention/BridgeDB Version:
Severity: Keywords: easy
Cc: isis, sysrqb Actual Points:
Parent ID: #9499 Points:
Reviewer: Sponsor:

Description

While testing for #9499, I realised that if I request https://127.0.0.1:6789/bridges?transport=obfs3 (localhost because it's a local test instance) then BridgeDB hands back bridge lines like this:

obfs3 245.102.100.252:23619 keyid=59ca743e89b508e16b8c7c6d2290efdfd14eea98 

which is wrong and will need to be fixed before we hand out fingerprints. This should be easy, just figure out where this string is getting added and kill it with fire.

Child Tickets

Attachments (1)

9499-keyid-field-for-fingerprints.png (55.8 KB) - added by isis 6 years ago.

Download all attachments as: .zip

Change History (6)

Changed 6 years ago by isis

comment:1 Changed 6 years ago by dcf

From what I know of pt-spec.txt, it's not wrong to have keyid= in there.

"We extend the bridge line format..."
https://gitweb.torproject.org/torspec.git/blob/782dacf43035892a0025b252f99018a6a1082b0e:/pt-spec.txt#l23
"For reference, the old bridge format was..."
https://gitweb.torproject.org/torspec.git/blob/782dacf43035892a0025b252f99018a6a1082b0e:/pt-spec.txt#l48

comment:2 in reply to:  1 ; Changed 6 years ago by isis

Replying to dcf:

From what I know of pt-spec.txt, it's not wrong to have keyid= in there.

"We extend the bridge line format..."
https://gitweb.torproject.org/torspec.git/blob/782dacf43035892a0025b252f99018a6a1082b0e:/pt-spec.txt#l23
"For reference, the old bridge format was..."
https://gitweb.torproject.org/torspec.git/blob/782dacf43035892a0025b252f99018a6a1082b0e:/pt-spec.txt#l48


See this comment from asn on #9499. Tor doesn't recognise the keyid= field; it wasn't ever implemented.

comment:3 in reply to:  2 Changed 6 years ago by isis

Status: newaccepted

Replying to isis:

Replying to dcf:
Tor doesn't recognise the keyid= field; it wasn't ever implemented.

Created #10614 for the error in pt-spec.txt.

comment:4 Changed 6 years ago by isis

Status: acceptedneeds_review

Fixed in my fix/10559-keyid-in-pt-lines branch.

comment:5 Changed 6 years ago by isis

Resolution: fixed
Status: needs_reviewclosed

Merged into 0.1.0

Note: See TracTickets for help on using tickets.