Opened 6 years ago

Closed 6 years ago

#10565 closed defect (fixed)

trouble compiling sun solaris 9 (SPARC)

Reported by: gemadar Owned by:
Priority: Medium Milestone: Tor: 0.2.5.x-final
Component: Core Tor/Tor Version:
Severity: Keywords:
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

When extracting from git and trying to compile I get the following:-

src/test/test_addr.c: In function `test_addr_sockaddr_to_str':
src/test/test_addr.c:902: error: syntax error before numeric constant
src/test/test_addr.c:922: error: invalid lvalue in unary `&'
src/test/test_addr.c:923: error: request for member `sun_family' in something not a structure or union
src/test/test_addr.c:924: error: request for member `sun_path' in something not a structure or union
src/test/test_addr.c:924: error: request for member `sun_path' in something not a structure or union
src/test/test_addr.c:925: error: invalid lvalue in unary `&'
make[1]: * [src/test/src_test_test-test_addr.o] Error 1
make[1]: Leaving directory `/export/home/ms/tor'
make:
* [all] Error 2

When investigating further it seems you try to declare the variable sun, which is a variable used by openssl so you cannot redeclare it, I fixed in my code changing it to suns and it now compiles fine.

Does this need sorting in the main build?

Child Tickets

Change History (3)

comment:1 Changed 6 years ago by nickm

Component: - Select a componentTor
Milestone: Tor: 0.2.4.x-final

Sure; I'd be happy to take a clean patch to fix this.

comment:2 Changed 6 years ago by nickm

Milestone: Tor: 0.2.4.x-finalTor: 0.2.5.x-final

Oops, this code isn't in 0.2.4.

comment:3 Changed 6 years ago by nickm

Resolution: fixed
Status: newclosed

I merged a fix as 34740a17ea8145f7d308991b710e759b90a0d87b . Please reopen if it doesn't fix the issue for you.

Note: See TracTickets for help on using tickets.