Opened 6 years ago

Closed 6 years ago

#10604 closed defect (fixed)

Tor status and error messages are not translated

Reported by: gk Owned by: brade
Priority: Medium Milestone:
Component: Applications/Tor Launcher Version:
Severity: Keywords: tbb-usability
Cc: mcs Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Starting up a non-en-US TBB shows untranslated messages like "Fishing handshake with first hop" in the progress window.

Child Tickets

Change History (9)

comment:1 Changed 6 years ago by gk

Keywords: tbb-usability added

comment:2 Changed 6 years ago by arma

Right. Here's what control-spec.txt has to say about it:

       "Summary" is a string that can
       be displayed to the user to describe the *next* task that Tor
       will tackle, i.e., the task it is working on after sending the
       status event. "Tag" is a string that controllers can use to
       recognize bootstrap phases, if they want to do something smarter
       than just blindly displaying the summary string; see Section 5
       for the current tags that Tor issues.

I wonder if we can rescue the bootstrap phase translations (per tag) from the Vidalia translations, since they're likely the same?

comment:3 Changed 6 years ago by mcs

Cc: mcs added

comment:5 Changed 6 years ago by brade

Summary: Tor status messages are not translatedTor status and error messages are not translated

We should also adopt Vidalia's translated strings to produce localized error messages. For example, Vidalia has translations for the REASON field within the BOOTSTRAP STATUS messages.

Also, per Nick's comment in #10431, we should include summary info (based on the TAG keyword) within error messages that Tor Launcher displays.

comment:6 Changed 6 years ago by nickm

Also, looking at #10431, it would be a good idea to report multiple messages if there have been multiple messages. For example, the reported events were:

650 STATUS_CLIENT WARN BOOTSTRAP PROGRESS=10 TAG=handshake_dir 
SUMMARY="Finishing handshake with directory server" WARNING="Unexpected 
identity in router certificate" REASON=IDENTITY COUNT=4 RECOMMENDATION=ignore

650 STATUS_CLIENT WARN BOOTSTRAP PROGRESS=10 TAG=handshake_dir 
SUMMARY="Finishing handshake with directory server" WARNING="DONE" 
REASON=DONE COUNT=5 RECOMMENDATION=warn

Note that if the *first* warning message had been reported too, the result would be comprehensible -- it was in part because the second message was reported instead that it wasn't.

comment:7 in reply to:  6 Changed 6 years ago by mcs

Replying to nickm:

Also, looking at #10431, it would be a good idea to report multiple messages if there have been multiple messages....

Good point. Currently, Tor Launcher follows the advice given in the RECOMMENDATION field (the first message had "ignore" and the second had "warn"). I am not sure what Vidalia does; we can certainly change the error reporting behavior in Tor Launcher. Are you suggesting that when we see RECOMMENDATION=warn we should report all of the previous problems too? Or maybe we need a user interface that is more suited to showing a stream of warning messages?

We also need to balance providing useful info. vs. overwhelming non-experts.

comment:8 Changed 6 years ago by brade

We committed a fix that pulls in the translated status and error strings from Vidalia:

https://gitweb.torproject.org/tor-launcher.git/commit/8ef16bb1475f3c1a6ea8e471e8bc027eaa957bb2

Next, we will look into adding the summary text to the the error alerts that are displayed by Tor Launcher.

comment:9 Changed 6 years ago by brade

Resolution: fixed
Status: newclosed

We committed a fix to include the summary information in bootstrap status error alerts:

https://gitweb.torproject.org/tor-launcher.git/commit/988a3ae20d00e930d161ed926b05d7c56d5b7e51

Closing this bug.

Note: See TracTickets for help on using tickets.