Tor status and error messages are not translated

Starting up a non-en-US TBB shows untranslated messages like "Fishing handshake with first hop" in the progress window.

added component::applications/tor launcher owner::brade priority::medium resolution::fixed status::closed tbb-usability type::defect labels

Trac:
Keywords: N/A deleted, tbb-usability added

Right. Here's what control-spec.txt has to say about it:

       "Summary" is a string that can
       be displayed to the user to describe the *next* task that Tor
       will tackle, i.e., the task it is working on after sending the
       status event. "Tag" is a string that controllers can use to
       recognize bootstrap phases, if they want to do something smarter
       than just blindly displaying the summary string; see Section 5
       for the current tags that Tor issues.

I wonder if we can rescue the bootstrap phase translations (per tag) from the Vidalia translations, since they're likely the same?

Trac:
Cc: N/A to mcs

We did a little research to find the relevant Vidalia code and strings:

Map bootstrap status tags to a Vidalia enum: https://gitweb.torproject.org/vidalia.git/blob/HEAD:/src/torcontrol/BootstrapStatus.cpp#l45

Map enum to a localizable string: https://gitweb.torproject.org/vidalia.git/blob/HEAD:/src/vidalia/MainWindow.cpp#l823

Localized strings sample: https://gitweb.torproject.org/vidalia.git/blob/HEAD:/src/vidalia/i18n/po/es/vidalia_es.po#l1739

We should also adopt Vidalia's translated strings to produce localized error messages. For example, Vidalia has translations for the REASON field within the BOOTSTRAP STATUS messages.

Also, per Nick's comment in #10431 (moved), we should include summary info (based on the TAG keyword) within error messages that Tor Launcher displays.

Trac:
Summary: Tor status messages are not translated to Tor status and error messages are not translated

Also, looking at #10431 (moved), it would be a good idea to report multiple messages if there have been multiple messages. For example, the reported events were:

650 STATUS_CLIENT WARN BOOTSTRAP PROGRESS=10 TAG=handshake_dir 
SUMMARY="Finishing handshake with directory server" WARNING="Unexpected 
identity in router certificate" REASON=IDENTITY COUNT=4 RECOMMENDATION=ignore

650 STATUS_CLIENT WARN BOOTSTRAP PROGRESS=10 TAG=handshake_dir 
SUMMARY="Finishing handshake with directory server" WARNING="DONE" 
REASON=DONE COUNT=5 RECOMMENDATION=warn

Note that if the first warning message had been reported too, the result would be comprehensible -- it was in part because the second message was reported instead that it wasn't.

Replying to nickm:

Also, looking at #10431 (moved), it would be a good idea to report multiple messages if there have been multiple messages....

Good point. Currently, Tor Launcher follows the advice given in the RECOMMENDATION field (the first message had "ignore" and the second had "warn"). I am not sure what Vidalia does; we can certainly change the error reporting behavior in Tor Launcher. Are you suggesting that when we see RECOMMENDATION=warn we should report all of the previous problems too? Or maybe we need a user interface that is more suited to showing a stream of warning messages?

We also need to balance providing useful info. vs. overwhelming non-experts.

We committed a fix that pulls in the translated status and error strings from Vidalia:

https://gitweb.torproject.org/tor-launcher.git/commit/8ef16bb1475f3c1a6ea8e471e8bc027eaa957bb2

Next, we will look into adding the summary text to the the error alerts that are displayed by Tor Launcher.

We committed a fix to include the summary information in bootstrap status error alerts:

https://gitweb.torproject.org/tor-launcher.git/commit/988a3ae20d00e930d161ed926b05d7c56d5b7e51

Closing this bug.

Trac:
Status: new to closed
Resolution: N/A to fixed

closed

moved to tpo/applications/tor-launcher#10604 (closed)