Opened 6 years ago

Closed 6 years ago

#10640 closed defect (fixed)

Fix about:tor's pointer position for RTL languages

Reported by: Sherief Owned by: brade
Priority: High Milestone:
Component: TorBrowserButton Version:
Severity: Keywords: tbb-usability
Cc: mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by mikeperry)

about:tor doesn't display the update pointer correctly for right-to-left locales (and possibly others).

Attached a screenshot of the problem.

Child Tickets

Attachments (1)

RTLPointer.png (71.6 KB) - added by Sherief 6 years ago.

Download all attachments as: .zip

Change History (8)

Changed 6 years ago by Sherief

Attachment: RTLPointer.png added

comment:1 Changed 6 years ago by mcs

Cc: mcs brade added

It looks like this is actually a problem with the about:tor page, which is generated locally (inside the browser) by Torbutton. The arrow is somewhat of a guess (for example, it will point to the wrong place after a user customizes the position of Torbutton on their browser toolbar), but we need to make it point to the correct place if no customization has been done.

comment:2 Changed 6 years ago by arlolra

Component: Tor CheckTor bundles/installation
Owner: changed from arlolra to erinn
Summary: Fix TorCheck's pointer position for RTL languagesFix about:tor's pointer position for RTL languages

comment:3 Changed 6 years ago by gk

Component: Tor bundles/installationTorBrowserButton
Owner: changed from erinn to mikeperry

comment:4 Changed 6 years ago by mikeperry

Description: modified (diff)
Keywords: tbb-usability added
Priority: normalmajor

comment:5 Changed 6 years ago by mcs

Owner: changed from mikeperry to brade
Status: newassigned

comment:6 Changed 6 years ago by brade

Status: assignedneeds_review

Mark and I committed a fix for this issue on the bug10640 branch, here:
https://gitweb.torproject.org/user/brade/torbutton.git/commit/4f770c71c5ce0e76edd9e7d6698998f672ed4da9

Previously, the code assumed that the Torbutton toolbar item was in a fixed/default location. When the icon is to the right of the URL bar, its location changes when the window width changes, so a hard-coded position will not be correct (and users can customize the toolbars as well). The new code gets the actual position of the Torbutton and makes the arrow point to it (if it is on the toolbar).

Mike, please review and decide if you want to take this fix for 3.5.1.

comment:7 Changed 6 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Merged and in 3.5.2. Thanks!

Note: See TracTickets for help on using tickets.