Opened 5 years ago

Closed 5 years ago

#10687 closed enhancement (fixed)

Add basque (eu) translation to TorLauncher extension

Reported by: baldarra Owned by: mikeperry
Priority: Medium Milestone:
Component: Applications/Tor Launcher Version:
Severity: Keywords:
Cc: mcs, brade Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Hi!
I'm the basque translator. I know mine is a minority language, that's why instead of asking to build a complete Tor Browser Bundle in basque, I'm just asking for adding the basque translation to the TorLauncher extension. That way, I can install the basque langpack from https://ftp.mozilla.org/pub/mozilla.org/firefox/releases/24.2.0esr/linux-x86_64/xpi/eu.xpi. Then, changing the general.useragent.locale variable from about:config, everything works except TorLauncher. When I open a new tab it correctly asks me if want to see the english version of websites. Firefox, NoScript, HTTPS-Everywhere and Torbutton are already available in basque, only TorLauncher lacks the basque translation. I have downloaded the source and added the basque translation (already completed) and everything works fine. Maybe this could be made for more languages also.
Thanks.
It's the first time I create a ticket, sorry if something is wrong.

Child Tickets

Change History (2)

comment:1 Changed 5 years ago by brade

Cc: mcs brade added
Owner: changed from brade to mikeperry
Status: newassigned

Mike -- I'm not sure what the protocol is for accepting translations. In Transifex, it looks like the Basque translation is complete but it hasn't been reviewed. Do you allow non-reviewed translations or should the reporter help complete the review process or ?

comment:2 Changed 5 years ago by mikeperry

Resolution: fixed
Status: assignedclosed

Well, these translations are as reviewed as anything else. They're also available on transifex for others to correct.

I think this is a reasonable request. We can go ahead and include the "eu" locale in the list in https://gitweb.torproject.org/user/brade/tor-launcher.git/blob/refs/heads/master:/localization/import-translations.sh and commit it to tor-launcher. It should then be straightforward to build basque XPIs.

The TBB language packs are governed by the list in https://gitweb.torproject.org/builders/tor-browser-bundle.git/blob/refs/heads/master:/gitian/versions, so we can simply omit eu from there to avoid the additional dist size (which is in fact a real constraint at the moment).

I've pushed this change to origin/master already.

Note: See TracTickets for help on using tickets.