Opened 6 years ago

Closed 6 years ago

#10708 closed enhancement (fixed)

Consider making Weather's daily t-shirt notifications a separate service

Reported by: karsten Owned by:
Priority: Medium Milestone:
Component: Metrics/Tor Weather Version:
Severity: Keywords: weather-rewrite
Cc: arma, phobos Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Roger brings up some more radical thoughts on the Weather rewrite. Trying to paraphrase what he said:

The current weather service is actually two services: a subscription service that sends email when a relay goes away, and a notification service that sends email to any relay operator who has qualified for a t-shirt. The latter service is unique and important for the Tor network, whereas the former service could be done in other ways, like a munin or something. If we fix the t-shirt service, Roger would care a great deal less about the subscription service being discontinued.

We should find out how many people use the subscription service before deciding something here. See #10699.

Even if we decide to split up Weather, we should still consider fixing the subscription part. But our priority may shift to fixing the t-shirt part first.

Child Tickets

Change History (1)

comment:1 Changed 6 years ago by karsten

Resolution: fixed
Status: newclosed

Hmm. I just had a closer look at the Weather code, and I think there's a misunderstanding how t-shirt notifications work.

Weather sends out welcome mails to relay operators whose relay got the Stable flag for the first time and invites them to subscribe to Weather. When a relay qualifies for a t-shirt, Weather notifies all subscribed users. But Weather does not send out t-shirt notifications to non-subscribed users. (Please somebody correct me if I read the code wrong.)

In my opinion, this process is quite a bit better than a service that only sends out emails when a relay qualifies for a t-shirt. The current process gets in touch with relay operators much earlier and shows them that we care about their relay. It's also a fine motivation to promise operators a t-shirt they can get weeks later if they continue running their relay, which is not the case if we only send them email when they already qualified.

So, if we want this somewhat more complex process (welcome mail, subscription, t-shirt notification), we'll need something like Weather. A simple script with local state is not sufficient for that.

I'm closing this ticket, because I think we should be focusing on fixing current Weather and not change its functionality for now.

Note: See TracTickets for help on using tickets.