Opened 6 years ago

Closed 5 years ago

#10716 closed defect (fixed)

Update drag-and-drop observer code to use DataTransfers

Reported by: gk Owned by: gk
Priority: High Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: ff31-esr, tbb-torbutton, TorBrowserTeam201409
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

Fixing https://bugzilla.mozilla.org/show_bug.cgi?id=939319 means that we need to change the drag-and-drop related code in Torbutton. A potential way to use the new observer is in branch bug_939319 in my public torbutton repo.

Child Tickets

Change History (5)

comment:1 Changed 5 years ago by erinn

Component: TorBrowserButtonTor Browser
Keywords: tbb-torbutton added
Owner: changed from mikeperry to tbb-team

comment:2 Changed 5 years ago by mikeperry

Keywords: TorBrowserTeam201409 added

comment:3 Changed 5 years ago by gk

Owner: changed from tbb-team to gk
Status: newassigned

comment:4 Changed 5 years ago by gk

Status: assignedneeds_review

See bug_10716_v2 in my public Torbutton repo for the code t review. Surprisingly, there is no need to QI to nsIDOMDataTransfer. Rather, if we do this an exception is thrown.

comment:5 Changed 5 years ago by mikeperry

Resolution: fixed
Status: needs_reviewclosed

Ok, this is merged. I added an XXX comment to remind us that the old API code was pre-FF31 and can eventually be removed.

Note: See TracTickets for help on using tickets.