Opened 10 years ago

Last modified 7 years ago

#1076 closed defect (Fixed)

unit parsing broken/changed from 0.2.1.19

Reported by: Sebastian Owned by:
Priority: Low Milestone:
Component: Core Tor/Tor Version: 0.2.2.1-alpha
Severity: Keywords:
Cc: Sebastian, nickm Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

It appears that d4b31cf98f85550155156726ad9f3424def07fb7
changed the behaviour of option parsing when a line like
"RelayBandwidthRate 50KBytes" is present. This will be interpreted as
50 bytes. Changing the line to read "RelayBandwidthRate 50 KBytes"
fixes the issue.

I'm unsure how to fix, it seems certain that we can't use
smartlist_split_string because we don't know where to split.

Problem found by Tas

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (6)

comment:1 Changed 10 years ago by Sebastian

Just to clarify: This is a bug that is _not_ in 0.2.1.19, only in 0.2.2.1

comment:2 Changed 10 years ago by nickm

It seems we could do pretty well with a tor_parse_float() that wraps strtod() in the same way
that tor_parse_long() wraps strtol(). I'll give it a try.

comment:3 Changed 10 years ago by nickm

There's a likely fix in the "bug1076" branch of my public repository at git://git.torproject.org/~nickm/git/tor.git

Once somebody else has had a chance to try it, if it works and looks good, I'll merge it.

comment:4 Changed 10 years ago by nickm

Fix verified by Sebastian and merged into master.

comment:5 Changed 10 years ago by nickm

flyspray2trac: bug closed.

comment:6 Changed 7 years ago by nickm

Component: Tor RelayTor
Note: See TracTickets for help on using tickets.