Restoring windows and tabs causes crash on exit

0. Extract TBB 3.5.1
1. In Torbutton, uncheck Don't record browsing history
2. In Firefox options, set startup to Show my windows and tabs from last time
3. Close TB
4. Open and close TB a few times
5. Open and close TB. It will crash on exit, every time.

Tested on Windows 7 64bit. This does not happen in a TBB with Firefox 17.

added MikePerry201504R TorBrowserTeam201504R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-4.5-alpha tbb-crash tbb-firefox-patch type::defect labels

Trac:
Cc: N/A to gk

Is it still happens for you with TBB 3.5.2?

Tested on Windows 7 64bit.

Can you post crash report generated by windows. It's usually stored in event logs forever. Control Panel -> System and Security -> View event logs (Administrative Tools section) Next you need to chose in viewer: Windows Logs -> Application It will show all events and you need to find your crash, should be with "Error" level. Double click it when found then it will open "Event properties" window. Click "Copy" button and paste it here (You probably don't want to paste it all, as it may contain some private stuff you probably cares like computer name, but we need 4 lines at least, about: Faulting application name, Faulting module name, Exception code, Fault offset)

Next you need to chose in viewer: Windows Logs -> Application It will show all events and you need to find your crash, should be with "Error" level. Double click it when found then it will open "Event properties" window. Click "Copy" button and paste it here.

Graphical explanation,

Faulting application name: firefox.exe, version: 24.3.0.0, time stamp: 0x386d4380 Faulting module name: nssckbi.dll_unloaded, version: 0.0.0.0, time stamp: 0x386d4380 Exception code: 0xc0000005 Fault offset: 0x69bce8b8 Faulting module path: nssckbi.dll

Nothing

Nothing

Nothing

Trac:
Component: TorBrowserButton to Firefox Patch Issues
Keywords: N/A deleted, tbb-crash added

Nothing

Tested on Windows 7 64bit. This does not happen in a TBB with Firefox 17.

What AV do you running?

Comparing files nssckbi.dll and NSSCKBI_patched.DLL
0000C58E: 18 10
0000C58F: C7 90
0000C590: 44 90
0000C591: 24 90
0000C592: 04 A1
0000C593: B8 3C
0000C594: E8 62
0000C595: BC C2
0000C597: C7 50
0000C598: 04 90
0000C599: 24 68

What do you think about this bin patch?

Replying to cypherpunks:

What do you think about this bin patch?

Doesn't crash for me (OP)

Nothing

Nothing

Trac:
start.cmd

batch file with defined NSS_DISABLE_UNLOAD for start tbb for windows

Doesn't crash for me (OP)

Can you test attached "start.cmd" batch file with non modified TBB? Place and run it from directory with "Start Tor Browser.exe" It should to prevent unloading dll, as workaround it should to prevent crash.

By any chance do you have problems with https sites for your crashed on exit TBB? When you visits this tracker with TBB does it show "This Connection is Untrusted" error message?