Opened 10 years ago

Closed 4 years ago

#1079 closed defect (not a bug)

"external application" warning, but I just want to save the file

Reported by: arma Owned by: tbb-team
Priority: Medium Milestone:
Component: Applications/Tor Browser Version:
Severity: Keywords: tbb-usability, tbb-torbutton
Cc: arma, gk Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description (last modified by arma)

Go to http://torrent.fedoraproject.org/ and click on one of the torrent
files, using Torbutton 1.2.2.

It will pop up a warning box, and I have to choose "launch application"
in order to be taken to the dialog where I can save the file.

This seems like the wrong order of operations.

Using iceweasel (3.0) on lenny.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Change History (9)

comment:1 Changed 10 years ago by mikeperry

I will look into it.. but when we have firefox randomly launching apps automatically for
exactly that case without notifying you, I think it may be best to err on the side of caution.

comment:2 Changed 6 years ago by arma

Component: TorbuttonTorBrowserButton
Description: modified (diff)
Keywords: tbb-usability added
Owner: set to mikeperry
Priority: minornormal

Re-componenting to a component Mike looks at.

This remains a problem even when you choose right-click-download on a file.

I wonder if we can skip this dialog when we know the user is only going to be downloading something? Or go even further and just choose 'download' for them, since we know they should never be running a new program from this dialog?

comment:3 Changed 6 years ago by arma

I just closed #8963 as a duplicate.

comment:4 Changed 5 years ago by mikeperry

This will be fixed by https://trac.torproject.org/projects/tor/ticket/9901#comment:74. We may want to dup this to #9901, since fixing #9901 via native code or the right API will also fix this.

See also #7439 for some example text for a new dialog, and #10482 for some other usability issues with the current dialog.

comment:5 Changed 5 years ago by gk

Cc: gk added
Version: 1.2.2

comment:6 Changed 5 years ago by gk

This ticket is now the one for the right fix:

"I think the right fix here is to remove external-app-blocker.js from Torbutton, and patch the Firefox app launching code to emit our custom confirmation dialog before actually launching the app (or create another observer for this purpose).

Unfortunately, the external app launching code itself is a little hairy and convoluted. The starting points are nsExternalHelperAppService::DoContent() and nsExternalHelperAppService::LoadURI(). It looks like there are still a few entrypoints there to launch external apps that happen before Mozilla tries to present their version of the app launch confirmation dialogs. Unfortunately, some of these points may happen in what appears to be compile-time generated C++ code.

I can also try to bring this to Mozilla's attention to see if they are willing to write a proper fix themselves, since this silent app launching behavior is a longstanding issue in their own confirmation dialog system." (see: #9901 comment 74)

comment:7 Changed 5 years ago by gk

#11587 is a duplicate.

comment:8 Changed 5 years ago by erinn

Component: TorBrowserButtonTor Browser
Keywords: tbb-torbutton added
Owner: changed from mikeperry to tbb-team

comment:9 Changed 4 years ago by mikeperry

Resolution: Nonenot a bug
Status: newclosed

We cleaned up this dialog significantly. I think I want to close this ticket, and if future usability studies find our prompt to still be a significant source of confusion, we can file a new ticket clearly describing what the confusion is now (as it will certainly be different than what arma wrote 5 years ago).

Note: See TracTickets for help on using tickets.