Opened 6 years ago

Closed 6 years ago

#10834 closed enhancement (fixed)

Configurable reCAPTCHA remoteip

Reported by: sysrqb Owned by: isis
Priority: Medium Milestone:
Component: Circumvention/BridgeDB Version:
Severity: Keywords: bridgedb-https, bridgedb-0.1.5
Cc: isis Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

reCAPTCHA takes a remoteip parameter during verification. Currently we submit a randomized IP address, but it will be good if this can be configured in the config.

Child Tickets

Change History (3)

comment:1 Changed 6 years ago by sysrqb

bug10834 in my repo. Mocking HTTPServer will be some work, the methods and functions aren't easily testable right now.

[0] https://travis-ci.org/sysrqbci/bridgedb/builds/18452368 (2.6 failed)

comment:2 in reply to:  1 Changed 6 years ago by isis

Keywords: bridgedb-https bridgedb-0.1.5 added
Owner: set to isis
Status: newaccepted

Replying to sysrqb:

bug10834 in my repo.

Merged for 0.1.5 [here https://gitweb.torproject.org/bridgedb.git/commit/2b8b557c2bd3526029b2a09bb48ba95c9e20ff3e]. Thanks!

I think it all looks okay, and I did a bunch of manual testing to make sure the web server was still functioning correctly. I have not yet staged it to test with the real descriptors.

Mocking HTTPServer will be some work, the methods and functions aren't easily testable right now.

[0] https://travis-ci.org/sysrqbci/bridgedb/builds/18452368 (2.6 failed)

I removed Python2.6 from .travis.yml because we have 2.7 and there's no reason to continue to worry about 2.6 bugs. :)

I'll try to look at finding a good way to mock HTTPServer and the objects it touches while travelling tomorrow. IIRC I found a good Twisted-compatible way to do this in ooni, but off the top of my head I don't remember and I'll probably need to dig a bit.

comment:3 Changed 6 years ago by isis

Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.