Opened 10 years ago

Last modified 10 years ago

#1084 closed defect (Fixed)

Torbutton does not preserve old HTTP_ACCEPT_LANGUAGE

Reported by: Ache Owned by:
Priority: Low Milestone:
Component: Applications/Torbutton Version: 1.2.2
Severity: Keywords:
Cc: Ache Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

With the setting "Spoof English US Browser" Torbutton does not restore old HTTP_ACCEPT_LANGUAGE when switched back, it still stays as "en-us,en;q=0.5", please fix.

[Automatically added by flyspray2trac: Operating System: All]

Child Tickets

Attachments (2)

torbutton-1.2.3-pre9.xpi (338.6 KB) - added by mikeperry 9 years ago.
torbutton-1.2.3-pre10.xpi (347.8 KB) - added by mikeperry 9 years ago.

Download all attachments as: .zip

Change History (13)

comment:1 Changed 9 years ago by mikeperry

Do you have a custom value for this pref? Torbutton does reset it to the default..

comment:2 Changed 9 years ago by Ache

1) The value comes from standard options (see below).
2) There is no real default since this setting is locale dependent. Browser's default is stopgap only when user not set his locale.
If you choose some non-English language in preferences (Tools, Options, Content, Languages), say, in that order:
Russian [ru]
English [en]
you'll got:
HTTP_ACCEPT_LANGUAGE = ru,en;q=0.5
as result.

comment:3 Changed 9 years ago by mikeperry

Ok, there should be a fix for this in the attachments tab. Please let me know if it works.

Changed 9 years ago by mikeperry

Attachment: torbutton-1.2.3-pre9.xpi added

comment:4 Changed 9 years ago by Ache

Thanx, works now.

comment:5 Changed 9 years ago by Ache

This moment is fixed, but I find more unpleasant bugs:
1) All popups opens about:blank instead of needed page even when TB is switched off. The workaround is to disable or uninstall TB.
2) I found all updates checkboxes in the Tools Options Advanced becomes cleared (TB is off).

comment:6 Changed 9 years ago by mikeperry

Are these new issues, or were they still there in 1.2.2? Also, is this Firefox 3.5 or 3.0?

comment:7 Changed 9 years ago by Ache

New issues not present in 1.2.2.
(BTW, I test popups on blogger.com, Design page, they are user-initiated)
FF 3.5.5

Changed 9 years ago by mikeperry

Attachment: torbutton-1.2.3-pre10.xpi added

comment:8 Changed 9 years ago by mikeperry

Ok, I've reproduced Issue #1 and have a fix that works for me in the attachments tab. Can you test it
on your site(s)? I don't have a blogger account.

I was unable to reproduce the update options bug in your issue #2. Do you have "Disable updates during
Tor usage" checked? I tried that option in FF3.5.5 and it still didn't cause problems for me..

Can you provide more details on when the checkboxes get cleared? Is it only on toggle? Or immediately?
Is it also something that just started happening now?

comment:9 Changed 9 years ago by Ache

1) Thanx, with pre10 popups works again.

2) Alas, I can't reproduce missing update checkboxes when TB off anymore. They are cleared at the momemnt TB is pressed. Yes, I have "Disable updates during Tor usage". Now they returned when TB is off, but at the time of my previous report I somehow got the situation when they are cleared AND TB was off (I remember it clearly). Don't know how I made it those time. Perhaps by restarting browser in different states, but now I can't reproduce it.

comment:10 Changed 9 years ago by mikeperry

Ok, I am going to mark this closed then. If #2 happens again, please file another bug.

comment:11 Changed 9 years ago by mikeperry

flyspray2trac: bug closed.
Fixed. Will appear in 1.2.3

Note: See TracTickets for help on using tickets.