Opened 6 years ago

Closed 5 years ago

#10870 closed defect (fixed)

Remove insertion_time_elem_t as redundant

Reported by: nickm Owned by:
Priority: Medium Milestone: Tor: 0.2.4.x-final
Component: Core Tor/Tor Version:
Severity: Keywords: 024-backport tor-relay
Cc: Actual Points:
Parent ID: Points:
Reviewer: Sponsor:

Description

The insertion_time_elem_t stuff is still left in our codebase, though our solution to #9093 puts a timestamp on every packed_cell_t, which makes the old code and structures unnecessary. Let's pull it out.

Child Tickets

Change History (7)

comment:1 Changed 6 years ago by nickm

Status: newneeds_review

See branch "no_itime_queue" on my public repository.

comment:2 Changed 6 years ago by nickm

Karsten says that one looks okay to him... but oops, 0.2.5 is more complicated. please have a look at no_itime_queue_025.

comment:3 Changed 6 years ago by karsten

Your no_itime_queue_025 branch looks good, too. (Again, I'm saying this only by reading changes, not test-compiling or testing.)

comment:4 Changed 6 years ago by nickm

Milestone: Tor: 0.2.5.x-finalTor: 0.2.4.x-final

Merged no_itime_queue_025 to master. Proposing no_itime_queue for inclusion in 0.2.4: needless complexity makes me twitchy.

comment:5 Changed 6 years ago by arma

Do we super need this in 0.2.4? It doesn't fix anything other than making something simpler?

comment:6 Changed 5 years ago by nickm

15:53 < nickm> I thnk we _should_ merge 10870
15:53 < nickm> It makes it easier to backport other stuff around that code, and 
               it's a clean removal of some code that we're never going to 
               seriously maintain
15:53 < armadev> works for me

With that, I'll merge.

comment:7 Changed 5 years ago by nickm

Resolution: fixed
Status: needs_reviewclosed
Note: See TracTickets for help on using tickets.